fix: [M3-8686] - fix Buttons data-qa attributes #11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
requested review from
jdamore-linode,
bnussman-akamai and
hkhalil-akamai
and removed request for
a team
abailly-akamai
commented
Oct 2, 2024
| @@ -93,7 +93,7 @@ export const SingleTextFieldForm = React.memo((props: Props) => { | |||
| /> | |||
| <ActionsPanel | |||
| primaryButtonProps={{ | |||
| 'data-testid': 'Button', | |||
| 'data-testid': 'button', | |||
There was a problem hiding this comment.
This is 2/2 of the main changes
jdamore-linode
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
🙌 Thanks @abailly-akamai!
I never noticed the console error, but I have noticed the random uppercased "Button" test ID -- happy to see this change!
abailly-akamai
changed the title
abailly-akamai
commented
Oct 2, 2024
| @@ -158,7 +158,7 @@ export const Button = React.forwardRef<HTMLButtonElement, ButtonProps>( | |||
| color={color} | |||
| compactX={compactX} | |||
| compactY={compactY} | |||
| data-testid={rest['data-testid'] || 'Button'} | |||
| data-testid={rest['data-testid'] || 'button'} | |||
There was a problem hiding this comment.
This is 1/2 of the main changes
|
Coverage Report: ✅ |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 36s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
409
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixing a console error that has bothered me for a long time!
Changes 🔄
ActionPanelPrimaryButtondata-qaattribute inSingleTextfieldFormHow to test 🧪
Reproduction steps
/profile/displayVerification steps
/profile/displayAs an Author I have considered 🤔
Check all that apply