Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8541, M3-8621] - Unit tests for CollapsibleTable and CollapsibleRow components #11016

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Sep 30, 2024

Description 📝

Unit test cases for CollapsibleTable and CollapsibleRow components.

Changes 🔄

  • Add unit test cases for CollapsibleTable and CollapsibleRow components.
  • Add missing cell from CollapsibleTable story.

Target release date 🗓️

N/A

How to test 🧪

Verification steps

  • Run yarn test CollapsibleTable --reporter verbose
  • Verify that all the test cases pass.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai added the Unit tests Improves unit test coverage label Sep 30, 2024
@pmakode-akamai pmakode-akamai self-assigned this Sep 30, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review September 30, 2024 11:05
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner September 30, 2024 11:05
@pmakode-akamai pmakode-akamai requested review from bnussman-akamai and abailly-akamai and removed request for a team September 30, 2024 11:05
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added coverage - this could/should easily be a cypress component test but this is helpful nonetheless.

Confirmed all new tests passing ✅

@pmakode-akamai pmakode-akamai force-pushed the M3-8541-8621-unit-tests-for-collapsibletable-and-collapsiblerow-components branch from 9e743ba to 2c377f3 Compare October 3, 2024 06:40
@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Coverage Report:
Base Coverage: 87.12%
Current Coverage: 87.19%

@pmakode-akamai pmakode-akamai merged commit c981cf4 into linode:develop Oct 3, 2024
20 checks passed
Copy link

cypress bot commented Oct 3, 2024

Cloud Manager E2E    Run #6614

Run Properties:  status check failed Failed #6614  •  git commit c981cf4ccf: test: [M3-8541, M3-8621] - Unit tests for CollapsibleTable and CollapsibleRow co...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6614
Run duration 29m 04s
Commit git commit c981cf4ccf: test: [M3-8541, M3-8621] - Unit tests for CollapsibleTable and CollapsibleRow co...
Committer Purvesh Makode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 409
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  stackscripts/create-stackscripts.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Create stackscripts > creates a StackScript with Any/All target image Screenshots Video
Flakiness  images/machine-image-upload.spec.ts • 1 flaky test

View Output Video

Test Artifacts
machine image > uploads machine image, mock failed to decompress failed event Screenshots Video
Flakiness  objectStorage/access-keys.smoke.spec.ts • 1 flaky test

View Output Video

Test Artifacts
object storage access keys smoke tests > can create access key - smoke Screenshots Video
Flakiness  linodes/create-linode-with-vlan.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Create Linode with VLANs > can assign new VLANs during Linode create flow Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Unit tests Improves unit test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants