Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8440] - Cypress tests for OBJ Gen 2 bucket access tab changes #10994

Merged
merged 13 commits into from
Oct 3, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Sep 24, 2024

Description 📝

Add test coverage for access and ssl/tls tab changes for bucket detail

Changes 🔄

  • create test file for bucket details testing changes for E0-E3 endpoints
  • added a mock intercept for getting bucket's access information (otherwise there would be an error notice on the Access tab)

Target release date 🗓️

9/30+

How to test 🧪

  • yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-details-gen2.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai marked this pull request as ready for review September 24, 2024 18:28
@coliu-akamai coliu-akamai requested a review from a team as a code owner September 24, 2024 18:28
@coliu-akamai coliu-akamai requested review from jdamore-linode and removed request for a team September 24, 2024 18:28
@coliu-akamai coliu-akamai requested a review from a team as a code owner September 24, 2024 18:29
@coliu-akamai coliu-akamai requested review from carrillo-erik and cpathipa and removed request for a team September 24, 2024 18:29
Copy link

github-actions bot commented Sep 24, 2024

Coverage Report:
Base Coverage: 86.98%
Current Coverage: 86.98%

Copy link
Contributor

@carrillo-erik carrillo-erik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! It's a small PR so there's not much to comment on. Approved ✅

@coliu-akamai coliu-akamai added Wait to Merge Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 26, 2024
@coliu-akamai coliu-akamai merged commit 1c6241d into linode:develop Oct 3, 2024
19 of 20 checks passed
Copy link

cypress bot commented Oct 3, 2024

Cloud Manager E2E    Run #6615

Run Properties:  status check passed Passed #6615  •  git commit 1c6241d6a0: test: [M3-8440] - Cypress tests for OBJ Gen 2 bucket access tab changes (#10994)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6615
Run duration 25m 41s
Commit git commit 1c6241d6a0: test: [M3-8440] - Cypress tests for OBJ Gen 2 bucket access tab changes (#10994)
Committer Connie Liu
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 414
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Object Storage Gen2 Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants