Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8593] - Copy updates in Create with CLI modal #10954

Merged
merged 29 commits into from
Sep 19, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Sep 17, 2024

Description 📝

Highlight the Pull Request's context and intentions.

Changes 🔄

List any change relevant to the reviewer.

  • The "SDK's" tab is corrected to read "SDKs".
  • The "Getting started" header is corrected to read "Getting Started".

Target release date 🗓️

9/30

Verification steps

(How to verify changes)

  • Navigate to API CLI Modal in linode create flow
  • Verify SDK tab and resource headings.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner September 17, 2024 16:40
@cpathipa cpathipa requested review from bnussman-akamai and coliu-akamai and removed request for a team September 17, 2024 16:40
@cpathipa cpathipa self-assigned this Sep 17, 2024
@cpathipa cpathipa marked this pull request as draft September 17, 2024 16:40
@cpathipa cpathipa changed the title M3 8593 change: [M3-8593] - Copy updates in Create with CLI modal Sep 17, 2024
@cpathipa cpathipa marked this pull request as ready for review September 17, 2024 16:44
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chandra! Copy looks good.

Screenshot 2024-09-17 at 10 04 10 AM

@@ -88,11 +88,11 @@ export const ApiAwarenessModal = (props: ApiAwarenessModalProps) => {
sendApiAwarenessClickEvent(`${type} Tab`, type);

const trackingKey =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change going to have an impact on LD metrics? (I'm guessing we'll just be able to aggregate the numbers from pre and post typo fix?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no impact on LD metrics. This will check the condition to fire the LD event with the appropriate key. In this case, we have also updated the check condition with respect to the tab name SDKs.

Copy link

github-actions bot commented Sep 17, 2024

Coverage Report:
Base Coverage: 86.93%
Current Coverage: 86.93%

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 17, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Chandra! approving pending Mariah's comments are resolved/answered 🎉

✅ confirmed copy update for 'Getting Started'
✅ confirmed copy update for SDKs

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 17, 2024
…ssModal/ApiAwarenessModal.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@mjac0bs
Copy link
Contributor

mjac0bs commented Sep 18, 2024

@cpathipa There are two Cypress failures on this branch, and at least one is probably legit, because I'm sure we were testing the previous copy. Can you confirm this is flake or fix:

linodes/create-linode-view-code-snippet.spec.ts
linodes/plan-selection.spec.ts

@cpathipa cpathipa requested a review from a team as a code owner September 18, 2024 21:21
@cpathipa cpathipa requested review from AzureLatte and removed request for a team September 18, 2024 21:21
@cpathipa
Copy link
Contributor Author

@cpathipa There are two Cypress failures on this branch, and at least one is probably legit, because I'm sure we were testing the previous copy. Can you confirm this is flake or fix:

linodes/create-linode-view-code-snippet.spec.ts linodes/plan-selection.spec.ts

Thanks @mjac0bs updated the create-linode-view-code-snippet.spec file 7ac5957, And lan-selection.spec passed running in local.

@cpathipa cpathipa merged commit 5f08477 into linode:develop Sep 19, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants