Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8180] - Notification Menu story #10950

Merged

Conversation

zaenab-akamai
Copy link
Contributor

@zaenab-akamai zaenab-akamai commented Sep 17, 2024

Description 📝

Add NotificationMenu Story to Storybook

Changes 🔄

  • Added NotificationMenu.stories.tsx
  • Updated MSW handlers

Target release date 🗓️

NA

How to test 🧪

Pull the PR and run yarn storybook. Navigate to Notification -> Notification Menu

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@zaenab-akamai zaenab-akamai changed the title M3 8180 notification menu story feat: [M3-8180] - Notification Menu story Sep 23, 2024
@zaenab-akamai zaenab-akamai marked this pull request as ready for review September 23, 2024 12:45
@zaenab-akamai zaenab-akamai requested a review from a team as a code owner September 23, 2024 12:45
@zaenab-akamai zaenab-akamai requested review from carrillo-erik, cpathipa and hana-akamai and removed request for a team September 23, 2024 12:45
@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 23, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like BillingActivityPanel.test.tsx is failing can you update the branch with latest from develop.

Copy link

Coverage Report:
Base Coverage: 87.13%
Current Coverage: 87.13%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 24, 2024
@zaenab-akamai zaenab-akamai merged commit ecdf2a9 into linode:develop Oct 3, 2024
19 of 20 checks passed
Copy link

cypress bot commented Oct 3, 2024

Cloud Manager E2E    Run #6612

Run Properties:  status check failed Failed #6612  •  git commit ecdf2a9046: feat: [M3-8180] - Notification Menu story (#10950)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6612
Run duration 27m 07s
Commit git commit ecdf2a9046: feat: [M3-8180] - Notification Menu story (#10950)
Committer zaenab-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 409
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants