Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter metrics for internal users #10943

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Sep 16, 2024

Description πŸ“

This PR avoid's firing LD metrics events for internal users.

Target release date πŸ—“οΈ

9/16

How to test πŸ§ͺ

Verification steps

(How to verify changes)

  • Verify LD events for DX tools shouldn't fire for internal accounts.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner September 16, 2024 14:46
@cpathipa cpathipa requested review from hana-akamai, carrillo-erik, jaalah-akamai and hkhalil-akamai and removed request for a team September 16, 2024 14:46
@cpathipa cpathipa self-assigned this Sep 16, 2024
Copy link

Coverage Report: βœ…
Base Coverage: 86.63%
Current Coverage: 86.63%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified events are not firing when useIsAkamaiAccount is mocked to true.

@hkhalil-akamai
Copy link
Contributor

One failing CI test passes locally.

@cpathipa cpathipa merged commit 0290edf into linode:release-v1.128.0 Sep 16, 2024
17 of 19 checks passed
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants