fix: [M3-7574] - Fix missing labels for User Permission radio buttons #10908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrillo-erik
requested review from
jaalah-akamai and
coliu-akamai
and removed request for
a team
carrillo-erik
added
the
Accessibility
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Sep 9, 2024
| value="null" | ||
| /> | ||
| } | ||
| label="None" |
There was a problem hiding this comment.
Rather than using the span.MuiFormControlLabel-label selector on the TableRow, we could apply the bold style here.
Honestly not sure which is better. Sometimes I'm hesitant with using MUI classnames because they could change in future MUI releases and cause the UI to break
Suggested change
| label="None" | |
| slotProps={{ | |
| typography: { | |
| sx: (theme) => ({ fontFamily: theme.font.bold }), | |
| }, | |
| }} | |
| label="None" |
coliu-akamai
approved these changes
Sep 9, 2024
coliu-akamai
added
Approved
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Sep 23, 2024
…linode#10908) * fix: [M3-7574] - Fix missing label for user permission radio btns * Add changeset
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes the problem in which the "None", "Read-Only", and "Read-Write" radio buttons under the "Specific Permissions" of the User Permissions page do not have any label or ARIA label, making it difficult to interact with the page using screen readers.
Changes 🔄
List any change relevant to the reviewer.
<label />element with MUI equivalent components.Target release date 🗓️
09/11/2024
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply