Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8171] - Add CheckoutSummary Story #10905

Conversation

harsh-akamai
Copy link
Contributor

Description πŸ“

Add CheckoutSummary Story to Storybook

Changes πŸ”„

  • Added CheckoutSummary Story

Target release date πŸ—“οΈ

N/A

How to test πŸ§ͺ

Verification steps

  • Run yarn storybook to test locally

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@harsh-akamai harsh-akamai self-assigned this Sep 9, 2024
@harsh-akamai harsh-akamai requested a review from a team as a code owner September 9, 2024 14:55
@harsh-akamai harsh-akamai requested review from bnussman-akamai and carrillo-erik and removed request for a team September 9, 2024 14:55
Copy link

github-actions bot commented Sep 9, 2024

Coverage Report: βœ…
Base Coverage: 86.4%
Current Coverage: 86.4%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going ahead and approving since the issue I noted in the previous PR is not unique to this story.

@harsh-akamai Can you create a backlog ticket for auditing & investigating our Storybook stories for these types of crashes and possible options for preventing them?

@harsh-akamai harsh-akamai merged commit 8944441 into linode:develop Sep 11, 2024
19 checks passed
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Sep 23, 2024
* feat: [M3-8171] - Add CheckoutSummary Story

* Added changeset: CheckoutSummary Story in Storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants