Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-6615, M3-8507] - Cypress test for empty Linode landing page and restricted user Linode landing page #10882

Conversation

subsingh-akamai
Copy link
Contributor

@subsingh-akamai subsingh-akamai commented Sep 4, 2024

Description 📝

Added cypress test for empty Linode landing page and restricted user Linode landing page

Changes 🔄

Added below cypress tests under in spec file - cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts

  • checks empty state on linode landing page
  • checks restricted user has no access to create linode on linode landing page

PRs

  • M3-6615
  • M3-8507

How to test 🧪

yarn cy:run -s cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts

Verification steps

When test executed using this command yarn cy:run -s cypress/e2e/core/linodes/smoke-linode-landing-table.spec.tsall tests should pass successfully and you should see new test added as per below screenshot

image

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@subsingh-akamai subsingh-akamai requested a review from a team as a code owner September 4, 2024 08:05
@subsingh-akamai subsingh-akamai requested review from jdamore-linode and removed request for a team September 4, 2024 08:05
@subsingh-akamai subsingh-akamai requested a review from a team as a code owner September 4, 2024 08:11
@subsingh-akamai subsingh-akamai requested review from jaalah-akamai and coliu-akamai and removed request for a team September 4, 2024 08:11
@pmakode-akamai pmakode-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Sep 4, 2024
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @subsingh-akamai, nice work! Made a couple small suggestions and offered some advice but overall this is already really solid 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changeset!

Copy link

github-actions bot commented Sep 5, 2024

Coverage Report:
Base Coverage: 86.2%
Current Coverage: 86.2%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks @subsingh-akamai!

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed tests pass

Nice work and comments throughout the tests were super helpful! 🎉
(also - just edited your PR comment so that the internal tickets aren't direct links - it shouldn't really matter since they're protected but just in case I guess?)

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Sep 5, 2024
@jdamore-linode jdamore-linode merged commit 4808caf into linode:develop Sep 6, 2024
19 checks passed
@subsingh-akamai subsingh-akamai deleted the M3_6615_tests_for_linode_empty_landing_page branch September 7, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants