Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: increased block storage max volume size to 16TB #10865

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

jmarmolm
Copy link
Contributor

Description 📝

The API is being updated to increase the max size for block storage volumes to 16TB, these are the changes necessary in the front end

Changes 🔄

  • Increase Block storage max volume size to 16 TB

@jmarmolm jmarmolm requested a review from a team as a code owner August 30, 2024 13:53
@jmarmolm jmarmolm requested review from jaalah-akamai and coliu-akamai and removed request for a team August 30, 2024 13:53
@jaalah-akamai
Copy link
Contributor

cc: @dajahi

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I didn't notice any other places we may need to update this. I tagged others who are working on this feature to double check

@jaalah-akamai jaalah-akamai added Ready for Review Volumes Relating to Volumes (aka Block Storage) Add'tl Approval Needed Waiting on another approval! labels Aug 30, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need a changeset for this @jaalah-akamai?

@jaalah-akamai jaalah-akamai changed the base branch from develop to release-v1.127.0 August 30, 2024 14:07
@jaalah-akamai jaalah-akamai changed the title upcoming: increased block storage max volume size to 16TB changed: increased block storage max volume size to 16TB Aug 30, 2024
@jaalah-akamai jaalah-akamai changed the title changed: increased block storage max volume size to 16TB change: increased block storage max volume size to 16TB Aug 30, 2024
@jaalah-akamai
Copy link
Contributor

cc: @abailly-akamai - I updated the release PR and our internal changelog doc

Copy link

Coverage Report:
Base Coverage: 82.88%
Current Coverage: 82.88%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Side note, not sure we need to have three separate const for each package. APIv4 could be the source of truth for this one and we remove the others.

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 30, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Side note, not sure we need to have three separate const for each package. APIv4 could be the source of truth for this one and we remove the others.

I think it would make sense to get rid of the /manager one and import directly from api-v4 for Cloud's purposes, but validation should be able to standalone with no api-v4 imports (I did a quick search to see if we do any currently and I didn't find any)

@bnussman-akamai
Copy link
Member

bnussman-akamai commented Aug 30, 2024

I agree with @abailly-akamai and @dwiley-akamai

but rather than using api-v4 as the source of truth, I think validation should be the source of truth because the dependence is like this:

validation ➡️ api-v4 ➡️ manager (or just validation ➡️ manager)

@abailly-akamai abailly-akamai merged commit 2986d19 into linode:release-v1.127.0 Sep 3, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review Volumes Relating to Volumes (aka Block Storage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants