Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7760] - Create SSH key drawer hidden by Rebuild Linode dialog #10833

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Aug 26, 2024

Description 📝

  • Quick fix to prevent the SSH Key drawer from being hidden by the Rebuild Linode dialog. We'll potentially look into redesigning the Rebuild Linode / Add a disk from Image flow (in a different ticket) as well

Target release date 🗓️

9/3

Preview 📷

Before After
image image

How to test 🧪

Reproduction steps

  • navigate to a Linode's page, click on three dot menu and Rebuild Linode option. Click 'Add an SSH Key' - drawer is hidden behind dialog

Verification steps

  • confirm drawer no longer hidden behind dialog
  • Confirm UI flow for places that use the CreateSSHKeyDrawer still work as expected
    • Create Linode
    • Add a disk to Linode via image
    • My profile >> SSH Keys >> Add an SSH Key

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Aug 26, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review August 26, 2024 15:48
@coliu-akamai coliu-akamai requested a review from a team as a code owner August 26, 2024 15:48
@coliu-akamai coliu-akamai requested review from mjac0bs, cpathipa and abailly-akamai and removed request for a team August 26, 2024 15:48
@coliu-akamai coliu-akamai added Bug Fixes for regressions or bugs Ready for Review labels Aug 26, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed bug, confirmed fix, and confirmed I didn't see any other issues with the layering of components in the Rebuild dialog.

Copy link

Coverage Report:
Base Coverage: 82.62%
Current Coverage: 82.62%

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming on the fix, the SSH drawer no longer hidden.

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! looking forward to refactoring those into pages to better the UX

@coliu-akamai coliu-akamai merged commit 9514b2c into linode:develop Aug 27, 2024
19 checks passed
@coliu-akamai coliu-akamai deleted the m3-7760 branch September 6, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes for regressions or bugs Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants