-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7686] - Restricted access UX for Databases #10794
feat: [M3-7686] - Restricted access UX for Databases #10794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage Report: ✅ |
…ricted-access-ux-databases
} | ||
|
||
export const DatabaseBackups = (props: Props) => { | ||
const { disabled = false } = props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a style thing, but we can probably remove the = false
in most, if not all cases, and have the same behavior.
All of our components are enabled by default, so passing disabled={undefined}
would keep them enabled, making = false
not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - looks much neater without it. I've updated the PR
…ricted-access-ux-databases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Banks's suggestion, but otherwise looks good! Thanks @zaenab-akamai!
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
The views under /databases have been updated to disable controls for restricted users
Changes 🔄
Target release date 🗓️
NA
Preview 📷
before_databases_restricted_ux.mov
after_database_restricted_ux.mov
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply