Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8369] – Add "Encrypt Volume" checkbox in Edit Volume drawer #10787

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Add a disabled "Encrypt Volume" checkbox in Edit Volume drawer that reflects the volume's encrypted status (i.e., encrypted volumes should have a checked disabled box, and unencrypted volumes should have an unchecked disabled box)

Target release date πŸ—“οΈ

9/3/24

Preview πŸ“·

Encrypted volume

Screenshot 2024-08-14 at 5 47 38β€―PM

Unencrypted volume

Screenshot 2024-08-14 at 5 47 29β€―PM

How to test πŸ§ͺ

Prerequisites

Point at the dev environment with the blockstorage-encryption tag on your account

Verification steps

Confirm the Edit Volume drawer has the BSE checkbox when the feature flag is on, and that the checkbox reflects the volume's encrypted status (i.e., encrypted volumes should have a checked disabled box, and unencrypted volumes should have an unchecked disabled box)

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption label Aug 14, 2024
@dwiley-akamai dwiley-akamai self-assigned this Aug 14, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner August 14, 2024 21:54
@dwiley-akamai dwiley-akamai requested review from jdamore-linode and AzureLatte and removed request for a team August 14, 2024 21:54
Copy link

github-actions bot commented Aug 14, 2024

Coverage Report: βœ…
Base Coverage: 82.62%
Current Coverage: 82.62%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 15, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage and the different states themselves look good!

I'm curious why we decided to go with a disabled checkbox here, rather than the lock icon we've been using elsewhere to denote encrypted, especially since this setting can't be changed.

This Branch Potentially
Screenshot 2024-08-16 at 10 16 49β€―AM Screenshot 2024-08-16 at 11 15 11β€―AM Screenshot 2024-08-16 at 11 15 27β€―AM

Though one difference here from elsewhere is displaying the tooltip regardless of encryption status.

@dwiley-akamai
Copy link
Contributor Author

I'm curious why we decided to go with a disabled checkbox here, rather than the lock icon we've been using elsewhere to denote encrypted, especially since this setting can't be changed.

I raised this with UX -- the disabled checkbox is more consistent with similar cases for LDE, and there's a chance that encrypting existing volumes will be supported down the line.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a chance that encrypting existing volumes will be supported down the line.

Got it. Thanks for the context!

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 16, 2024
@dwiley-akamai dwiley-akamai merged commit 0083246 into linode:develop Aug 19, 2024
19 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8369-edit-volume-drawer-encrypt-checkbox branch August 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants