-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8170] - Add CheckoutBar Story #10784
feat: [M3-8170] - Add CheckoutBar Story #10784
Conversation
Coverage Report: β
|
97915c3
to
8d8660c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! Had a few thoughts/comments
-
Could we change the text color of the children and agreement/footers? I can't see them unless I highlight the text. Maybe a color that works in both light/dark mode, or use the theme
-
Could we add some documentation for the props of CheckoutBar so that we can see their descriptions in the story? For example (see corresponding documentation)
-
Could we also add some tests for the CheckoutBar component?
We did a whole bunch of storybook migrations late last year - some of these PRs might be helpful to look at: here and here
packages/manager/src/components/CheckoutBar/CheckoutBar.stories.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/CheckoutBar/CheckoutBar.stories.tsx
Outdated
Show resolved
Hide resolved
8d8660c
to
c5415aa
Compare
Sure @coliu-akamai, but this PR is focused on Storybook. Could we have a separate ticket for adding tests to the CheckoutBar component? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we can go with a separate ticket for tests - would you be able to create one? Thanks for the changes + good work!
left one small comment below π
packages/manager/src/components/CheckoutBar/CheckoutBar.stories.tsx
Outdated
Show resolved
Hide resolved
@coliu-akamai I have created a new ticket (M3-8463) for tests. Keeping this one as a todo.. |
a7aec32
to
6f51e72
Compare
6f51e72
to
322071c
Compare
Description π
Add CheckoutBar Story to Storybook
Changes π
List any change relevant to the reviewer.
Target release date ποΈ
N/A
How to test π§ͺ
Verification steps
As an Author I have considered π€
Check all that apply