Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8149] - Add test for Linode create error flows #10761

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Aug 7, 2024

Description 📝

Add Cypress integration tests using mock API data to confirm that Cloud Manager behaves gracefully when errors occur during the Linode create flow.

Changes 🔄

  • Add util function to mock error response.
  • Add new test to confirm error handling behaviour during the Linode create flow.

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Aug 7, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner August 7, 2024 18:53
@AzureLatte AzureLatte requested review from cliu-akamai and removed request for a team August 7, 2024 18:53
@AzureLatte AzureLatte requested a review from a team as a code owner August 7, 2024 18:55
@AzureLatte AzureLatte requested review from dwiley-akamai and hana-akamai and removed request for a team August 7, 2024 18:55
Copy link

github-actions bot commented Aug 7, 2024

Coverage Report:
Base Coverage: 82.62%
Current Coverage: 82.62%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes in CI ✅ (I observed timeout failures locally)

* - Confirms error message can show up during Linode create flow.
* - Confirms Linode can be created after retry.
*/
it('unexpected error show up during Linode create flow', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('unexpected error show up during Linode create flow', () => {
it('shows unexpected error during Linode create flow', () => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@AzureLatte
Copy link
Contributor Author

E2E failure is not related with this change

@AzureLatte AzureLatte added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Aug 20, 2024
@AzureLatte AzureLatte merged commit dd19e75 into linode:develop Aug 20, 2024
18 of 19 checks passed
@AzureLatte AzureLatte deleted the M3-8149 branch August 20, 2024 16:26
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Aug 21, 2024
* Add test for Linode create error flows

* Added changeset: Add test for Linode create error flows

* update after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants