feat: [M3-7685] - Show empty Kubernetes landing page with disabled create button for restricted users #10756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate button for restricted users
zaenab-akamai
requested review from
jaalah-akamai and
coliu-akamai
and removed request for
a team
jaalah-akamai
approved these changes
Aug 7, 2024
| @@ -9,6 +9,7 @@ export const grantTypeMap = { | |||
| firewall: 'Firewalls', | |||
| image: 'Images', | |||
| linode: 'Linodes', | |||
| lkeCluster: 'Clusters', | |||
There was a problem hiding this comment.
I think this code comment will bring some clarity that it's mainly used to improve UX
Suggested change
| lkeCluster: 'Clusters', | |
| lkeCluster: 'Clusters', // Note: Not included in the user's grants returned from the API. |
There was a problem hiding this comment.
Nit: Can we also rename this to lke: LKE Clusters?
| it('should have the "Create Cluster" button disabled for restricted users', () => { | ||
| queryMocks.useProfile.mockReturnValue({ data: { restricted: true } }); | ||
|
|
||
| const { container } = render(wrapWithTheme(<KubernetesLanding />)); |
There was a problem hiding this comment.
We should be able to use renderWithTheme in these tests instead of render(wrapWithTheme())
There was a problem hiding this comment.
Hi @jaalah-akamai, I've updated the PR as you suggested
coliu-akamai
approved these changes
Aug 7, 2024
|
Coverage Report: ✅ |
This was referenced Aug 16, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: [M3-7685] - Show empty Kubernetes landing page with disabled create button for restricted users
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to introduce notifications on landing pages, restricting entry to users without the required permissions.
The existing "Unauthorized" view for restricted users on https://cloud.linode.com/kubernetes/clusters has been replaced with the empty Kubernetes landing page, with the "Create Cluster" button disabled.
Changes 🔄
Target release date 🗓️
NA
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.Verification steps
Additionally, check if the same view is enabled for a user with full access
As an Author I have considered 🤔
Check all that apply