-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8218] - Obj fix for crashing accesskey page when relevant customer tags are not added. #10555
Merged
cpathipa
merged 3 commits into
linode:release-v1.121.0
from
cpathipa:obj-fix-crashing-accesskey-page
Jun 10, 2024
Merged
upcoming: [M3-8218] - Obj fix for crashing accesskey page when relevant customer tags are not added. #10555
cpathipa
merged 3 commits into
linode:release-v1.121.0
from
cpathipa:obj-fix-crashing-accesskey-page
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpathipa
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
June 7, 2024 16:35
cpathipa
changed the title
Obj fix crashing accesskey page
upcoming: [M3-8218] - Obj fix for crashing accesskey page when relevant customer tags are not added.
Jun 7, 2024
β¦stomer tags are not added
Coverage Report: β
|
hana-akamai
approved these changes
Jun 7, 2024
bnussman-akamai
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that I didn't crash when visiting Obj pages
abailly-akamai
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Jun 10, 2024
This was referenced Jun 10, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
This PR prevents causing potential defect of crashing the Access key landing page when flag is on but no tags are assigned to the customer.
Target release date ποΈ
6/10
How to test π§ͺ
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered π€
Check all that apply