Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7717] - Fix leading whitespace in list of Linode and Nodebalancer links for Firewall Services #10527

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented May 29, 2024

Description 📝

Tiny PR to close out a ticket I made many months ago that was sitting in the backlog.

On the Firewalls landing page, linked linodes and NBs in the Services column list have some extra leading white space included in the link.

Changes 🔄

  • Moved the comma and spacing out of the Link component.
  • Very minor string clean up.

Target release date 🗓️

6/10

Preview 📷

Before After
Screenshot 2024-05-29 at 1 52 30 PM Screenshot 2024-05-29 at 1 52 03 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have a combination of at least 4 linodes or nodebalancers on your account, or create them.

Reproduction steps

(How to reproduce the issue, if applicable)

  1. Go to https://cloud.linode.com/firewalls.
  2. Have an existing firewall or create one.
  3. Attach at least 2 nodebalancers/linodes/any combination thereof to the firewall.
  4. Hover over the second or greater link in the list and observe the leading whitespace included in the link.

Verification steps

(How to verify changes)

  1. Check out this branch and go to http://localhost:3000.
  2. Have an existing firewall or create one.
  3. Attach at least 2 nodebalancers/linodes/any combination thereof to the firewall.
  4. Hover over the second or greater link in the list and observe the leading whitespace is not included in the link, nor are commas.
  5. Confirm no regressions when adding/removing >3 devices.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this May 29, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner May 29, 2024 21:46
@mjac0bs mjac0bs requested review from dwiley-akamai and carrillo-erik and removed request for a team May 29, 2024 21:46
Copy link

github-actions bot commented May 29, 2024

Coverage Report:
Base Coverage: 82.28%
Current Coverage: 82.28%

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label May 30, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma and leading whitespace no longer hyperlinked ✅

Screenshot 2024-05-30 at 4 30 59 PM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 31, 2024
@mjac0bs mjac0bs merged commit cbb668a into linode:develop May 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants