fix: Delete testing error introduced by mistake #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
requested review from
hana-akamai,
AzureLatte and
jdamore-linode
and removed request for
a team
jdamore-linode
approved these changes
May 23, 2024
|
I'll approve this when I get back home, I'm out running an errand 🛻 Wish I could just approve from this account 🙄 |
|
Coverage Report: ✅ |
mjac0bs
approved these changes
May 23, 2024
packages/manager/.changeset/pr-10514-tech-stories-1716499244555.md
Outdated
Show resolved
Hide resolved
bnussman-akamai
approved these changes
May 23, 2024
hkhalil-akamai
force-pushed
the
images-drawer-error
branch
from
98cac4a
to
098c187
Compare
|
@mjac0bs @bnussman-akamai changesets were accidentally included from another branch -- deleted. |
bnussman-akamai
approved these changes
May 24, 2024
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
In #10466 I accidentally committed a
Promise.rejectthat was intended to test error handling inImagesDrawer.Changes 🔄
How to test 🧪
Verify images can be edited without generating the test error.