test: [M3-6609] - Add Linode details page assertion for LISH via SSH Info #10513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureLatte
requested review from
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
|
Checking conflicts now. Will move to "ready for review" after conflicts resolved |
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
May 24, 2024
jdamore-linode
approved these changes
May 24, 2024
There was a problem hiding this comment.
Looks great @AzureLatte, posted a small suggestion but it's not a big deal! This addition looks really good as-is 👍
Comment on lines
134
to
143
| cy.contains('LISH Console via SSH') | ||
| .should('be.visible') | ||
| .next() // Navigate to the next element which should be the value | ||
| .invoke('text') // Get the text of the next element | ||
| .then((text) => { | ||
| // Example assertion (ssh -t <Linode account username>@lish-<Linode region>.linode.com <Linode label>) | ||
| expect(text).equal( | ||
| `ssh -t ${username}@lish-${linodeRegion.id}.linode.com ${linodeLabel}` | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| cy.contains('LISH Console via SSH') | |
| .should('be.visible') | |
| .next() // Navigate to the next element which should be the value | |
| .invoke('text') // Get the text of the next element | |
| .then((text) => { | |
| // Example assertion (ssh -t <Linode account username>@lish-<Linode region>.linode.com <Linode label>) | |
| expect(text).equal( | |
| `ssh -t ${username}@lish-${linodeRegion.id}.linode.com ${linodeLabel}` | |
| ); | |
| }); | |
| cy.contains('LISH Console via SSH') | |
| .should('be.visible') | |
| .closest('tr') | |
| .within(() => { | |
| cy.contains(`ssh -t ${username}@lish-${linodeRegion.id}.linode.com ${linodeLabel}`).should('be.visible'); | |
| }); |
Very minor suggestion: here's a slightly more straightforward way to assert the SSH command is shown, with two minor benefits: it's slightly less dependent on the DOM structure, and it confirms that the SSH command is visible in addition to being present in the DOM
AzureLatte
added
e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add Cypress assertions to confirm that the information displayed in the "LISH Console via SSH" section on Linode details pages is correct.
Changes 🔄
List any change relevant to the reviewer.
How to test 🧪
As an Author I have considered 🤔
Check all that apply