-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [OCA-1345] - June 10 2024 Marketplace Release #10500
feat: [OCA-1345] - June 10 2024 Marketplace Release #10500
Conversation
Coverage Report: ✅ |
Could you do us a big favor and merge the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The |
}, | ||
description: `Couchbase Enterprise Server is a high-performance NoSQL database, built for scale. Couchbase Server is designed with memory-first architecture, built-in cache and workload isolation.`, | ||
logo_url: 'couchbase.svg', | ||
name: 'Couchbase Enterprise Server Cluster', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be
name: 'Couchbase Enterprise Server Cluster', | |
name: 'Couchbase Cluster', |
so that it matches what is in packages/manager/src/features/StackScripts/stackScriptUtils.ts
This should fix the failing test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bnussman-akamai, confirmed that this change will fix the test and double checked that the app/its info drawer continue to work
Edit: Also want to call out (slash confirm) that an equivalent change will also be needed in oneClickAppsv2.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linode Create v2 bases everything off the stackscrpt ID so Linode Create v2 is actually working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've corrected the Couchbase Cluster name in oneClickApps.ts and replicated the change in oneClickAppsv2.ts for consistency.
@jdamore-linode I've updated the logo svg names. There is a step in the admin backend where we declare the asset name for the logo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @tbaka! Confirmed that the cassandra logo is displayed and the test is passing with your change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
howdy @bnussman-akamai. small updates. Apache Cassandra is being delayed until further notice, so I have removed it from the PR. I believe the issue with the gradient is that I set it to pure white as the end color. I've tweaked that value down to a dark gray, but I'm not an expert on the design elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
Description 📝
Includes new Marketplace Apps for June release, Apache Kafka Cluster and Couchbase Enterprise Server Cluster.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
June 10 2024