Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OCA-1345] - June 10 2024 Marketplace Release #10500

Merged

Conversation

tbaka-akamai
Copy link
Contributor

Description 📝

Includes new Marketplace Apps for June release, Apache Kafka Cluster and Couchbase Enterprise Server Cluster.

Changes 🔄

List any change relevant to the reviewer.

  • adds svg assets
  • adds oneClickApps.ts entries
  • adds stackScriptUtils.ts entries

Target release date 🗓️

June 10 2024

@tbaka-akamai tbaka-akamai requested a review from a team as a code owner May 21, 2024 20:21
@tbaka-akamai tbaka-akamai requested review from carrillo-erik and AzureLatte and removed request for a team May 21, 2024 20:21
Copy link

github-actions bot commented May 21, 2024

Coverage Report:
Base Coverage: 81.74%
Current Coverage: 81.74%

@bnussman-akamai bnussman-akamai changed the title feat:[OCA-1345] June 10 2024 Marketplace Release feat: [OCA-1345] June 10 2024 Marketplace Release May 22, 2024
@bnussman-akamai
Copy link
Member

Could you do us a big favor and merge the latest develop into this PR and then add the new apps to oneClickAppsv2.ts in addition to the existing files? We're in progress of simplifying how things work and for now, we'll need to add apps in both places

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bnussman-akamai
Copy link
Member

The oneClickApps/one-click-apps.spec.ts test is failing ⛔️, but I'm not sure why. @jdamore-linode, could you take a look if you have some time?

},
description: `Couchbase Enterprise Server is a high-performance NoSQL database, built for scale. Couchbase Server is designed with memory-first architecture, built-in cache and workload isolation.`,
logo_url: 'couchbase.svg',
name: 'Couchbase Enterprise Server Cluster',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be

Suggested change
name: 'Couchbase Enterprise Server Cluster',
name: 'Couchbase Cluster',

so that it matches what is in packages/manager/src/features/StackScripts/stackScriptUtils.ts

This should fix the failing test

Copy link
Contributor

@jdamore-linode jdamore-linode May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnussman-akamai, confirmed that this change will fix the test and double checked that the app/its info drawer continue to work
Screenshot 2024-05-24 at 1 09 46 PM

Edit: Also want to call out (slash confirm) that an equivalent change will also be needed in oneClickAppsv2.ts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linode Create v2 bases everything off the stackscrpt ID so Linode Create v2 is actually working fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected the Couchbase Cluster name in oneClickApps.ts and replicated the change in oneClickAppsv2.ts for consistency.

@jdamore-linode
Copy link
Contributor

I'm not able to get the Cassandra logo to render in the app list (it renders fine in the drawer, though). It seems like Cloud is looking for apachecassandra.svg instead of cassandra.svg
cassandralogo

I do see that the icon_url property returned by the API is apachecassandra.svg and not cassandra.svg so I suspect that's why -- I guess it needs to be renamed to apachecassandra.svg here (and updated in .ts files)

@tbaka-akamai
Copy link
Contributor Author

tbaka-akamai commented May 24, 2024

@jdamore-linode I've updated the logo svg names. There is a step in the admin backend where we declare the asset name for the logo:
Screenshot 2024-05-24 at 1 09 26 PM
this is what was causing the mismatch. I made the same formatting change to Apache Kafka for consistency.

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @tbaka! Confirmed that the cassandra logo is displayed and the test is passing with your change

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Should we do anything about the lack of gradient background for Couchbase?

Screenshot 2024-05-24 at 3 20 38 PM

@tbaka-akamai
Copy link
Contributor Author

howdy @bnussman-akamai. small updates. Apache Cassandra is being delayed until further notice, so I have removed it from the PR.

I believe the issue with the gradient is that I set it to pure white as the end color. I've tweaked that value down to a dark gray, but I'm not an expert on the design elements.

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label May 30, 2024
@bnussman-akamai bnussman-akamai changed the title feat: [OCA-1345] June 10 2024 Marketplace Release feat: [OCA-1345] - June 10 2024 Marketplace Release Jun 3, 2024
@bnussman-akamai bnussman-akamai merged commit cae54e8 into linode:develop Jun 3, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants