Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8062] - Replace PG feature flag restriction with useIsPlacementGroupsEnabled #10431

Merged
merged 2 commits into from
May 2, 2024

Conversation

carrillo-erik
Copy link
Contributor

@carrillo-erik carrillo-erik commented May 2, 2024

Description 📝

Replaces a remaining implementation of the feature flag restriction for Placement Groups feature with the recently created utility function useIsPlacementGroupsEnabled().

Changes 🔄

List any change relevant to the reviewer.

  • Straight forward replacement of one function with another.
  • No UI/UX changes.

Preview 📷

Feature Flag Off Feature Flag On
Screenshot 2024-05-02 at 6 06 47 AM Screenshot 2024-05-02 at 6 06 58 AM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have the placement-group customer tag on the user account used for testing.
  • Using the Cloud Manager Dev Tools:
    • Enable and Disable the Placement Groups feature flag to test functionality.

Verification steps

(How to verify changes)

  • Verify that the PlacementGroup feature is restricted to users who have the Placement Group capability in their account by toggling the Placement Groups feature flag in the Cloud Manger Developer Tools.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik self-assigned this May 2, 2024
@carrillo-erik carrillo-erik requested a review from a team as a code owner May 2, 2024 13:24
@carrillo-erik carrillo-erik requested review from bnussman-akamai, hkhalil-akamai and abailly-akamai and removed request for a team May 2, 2024 13:24
Copy link

github-actions bot commented May 2, 2024

Coverage Report:
Base Coverage: 81.82%
Current Coverage: 81.82%

@carrillo-erik carrillo-erik merged commit 429c01c into linode:develop May 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants