Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7781 & M3-7782] - Add Cypress integration tests for Placement Group deletion flows #10425

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

Adds a couple integration tests for Placement Group deletion flows:

  • With Linodes attached
  • Without Linodes attached

Changes 🔄

  • Adds deletion tests in delete-placement-groups.spec.ts
  • Fixes a mistake in PG mock utils where an empty array was being passed where an argument should've been used
  • Renames mock utils file from vm-placement.ts to placement-groups.ts

How to test 🧪

We can rely on CI, or run the tests manually:

yarn && yarn build && yarn start:manager:ci, then

yarn cy:run -s "cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts"

Alternatively you can use yarn cy:debug to watch the tests run.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this Apr 30, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner April 30, 2024 20:44
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team April 30, 2024 20:44
@jdamore-linode jdamore-linode requested a review from a team as a code owner April 30, 2024 20:45
@jdamore-linode jdamore-linode requested review from dwiley-akamai and abailly-akamai and removed request for a team April 30, 2024 20:45
Copy link

github-actions bot commented Apr 30, 2024

Coverage Report:
Base Coverage: 81.82%
Current Coverage: 81.82%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks @jdamore-linode

Test looks great and is testing all the right things ✅
I'll try to get to some others this week

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally & remotely ✅
Code review ✅

@jdamore-linode jdamore-linode merged commit 94b2db4 into linode:develop May 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants