-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager #10397
upcoming: [DI-18311] - Adding CloudPulse section to Cloud Manager #10397
Conversation
…moving unused Component
…the CloudPulse component
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I approve this I need some context.
Are you just stubbing this in? If you are, this is fine, with the exception of changing the "2024" value in the time drop down to "Year to date".
If you're not stubbing this in, I need to see the UX design you're referencing, because what you have is pretty rough.
For the 1st phase we are going with basic user journey functionalities utilizing the cloud manager components. This eventually will have a revised versions as we progressed. Regarding the dates, we will remove the years from that, as we will support only max of 30 days duration only |
packages/manager/src/features/CloudPulse/Dashboard/DashboardLanding.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/shared/TimeRangeSelect.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Overview/GlobalFilters.tsx
Outdated
Show resolved
Hide resolved
Thank you, @jaalah-akamai .Can I mark those conversations as resolved ? |
@santoshp210 Just a heads up that merging in the latest changes from |
…-global-filters Merging the latest develop changes to resolve test failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and for addressing feedback!
Description 📝
Added a CloudPulseTab component
Added a dashboard landing component
Added a RegionSelect component
Added a TimeRange component
Added a Global Filters component to manage the filters
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />
tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply