Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-7905] - Update PG landing page table #10318

Merged
merged 3 commits into from
Mar 28, 2024
Merged

upcoming: [M3-7905] - Update PG landing page table #10318

merged 3 commits into from
Mar 28, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Mar 26, 2024 •
edited
Loading

Description 📝

This PR brings a few updates to the PG landing page table, stemming from new UI/UX requirements.

Changes 🔄

  • rename getAffinityEnforcement to getAffinityTypeEnforcement
  • Add two new columns: "Affinity Type" & "Affinity Type Enforcement"
  • Remove affinity type from label (note: will be done in other places in subsequent PRs)
  • Fix filtering of PGs (debounced + loading icon + no results)
  • Add default rendering for missing max linodes

Preview 📷

localhost_3000_placement-groups (3)

How to test 🧪

Prerequisites

  • ⚠️ have the dev admin placement-group customer tag ⚠️
  • Switch to the dev API
  • Have the "Placement Group" feature flag on
  • Have MSW off

Verification steps

  • Navigate to http://localhost:3000/placement-groups
  • Have at least two placement groups
    • One with a "strict" affinity type enforcement
    • One with a "flexible" affinity type enforcement
  • Verify sorting for all sortable columns
  • Verify search/filtering behavior

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Mar 26, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review March 26, 2024 21:36
@abailly-akamai abailly-akamai requested a review from a team as a code owner March 26, 2024 21:36
@abailly-akamai abailly-akamai requested review from carrillo-erik and hkhalil-akamai and removed request for a team March 26, 2024 21:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 81.69%
Current Coverage: 81.69%

bnussman-akamai
bnussman-akamai approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 27, 2024
mjac0bs
mjac0bs approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting changes! Thank you for pushing for the improvements to how we're handling the affinity type - goodbye label imposter.

Minor feedback: I think we have more columns displaying at tablet and mobile screen sizes than we typically do, so if there are any additional that we/UX feel we are able to collapse, that would improve the appearance of the table row with the action menu items.

Mobile Tablet
Screenshot 2024-03-27 at 9 59 08 AM Screenshot 2024-03-27 at 9 59 39 AM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 27, 2024
hkhalil-akamai
hkhalil-akamai approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new columns look good! Left one minor comment regarding UI.

packages/manager/src/features/PlacementGroups/PlacementGroupsLanding/PlacementGroupsLanding.tsx Outdated
size="small"
sx={{ padding: 'unset' }}
>
<CloseIcon sx={{ color: '#aaa !important' }} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When typing, I noticed the end icon flickers between the loading icon and the close icon. It might be better to have the two icons side by side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call - fixed!

@abailly-akamai
Copy link
Contributor Author

@mjac0bs sounds good, removed an extra column on mobile 👍

@abailly-akamai abailly-akamai merged commit 7187a7f into linode:develop Mar 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjac0bs mjac0bs mjac0bs approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@hkhalil-akamai hkhalil-akamai hkhalil-akamai approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/frontend

Assignees

@abailly-akamai abailly-akamai

Labels
Approved Multiple approvals and ready to merge! Placement Groups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abailly-akamai @mjac0bs @bnussman-akamai @hkhalil-akamai