-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7517 & M3-7519] - Cypress integration tests for Child -> Parent and Child -> Child account switching #10288
test: [M3-7517 & M3-7519] - Cypress integration tests for Child -> Parent and Child -> Child account switching #10288
Conversation
… billing page after switch
mockAlternateChildAccountToken.expiry!, | ||
mockAlternateChildAccountToken.scopes | ||
); | ||
// TODO Confirm whether toast is intended here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to call this out: do we expect a toast notification to appear when switching from a Child account to another Child account? Seems like proxy_user
doesn't get reset in local storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdamore-linode Yea that's a good callout. I'll track this in a new ticket!
…d->Parent and Child->Child flows
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through this spec and I think this is well covered, thank you, Joe!
Description 📝
Adds a couple Cypress tests to test the account switching for Parent -> Child and Child -> Child flows. Additionally makes some fixes and improvements to the existing tests (especially mocks) to resolve some inaccuracies.
I opted to only test these flows from the billing page to cut back on tests required (essentially for the sake of our Cypress Cloud usage) -- my thought is we already have the existing test to cover using the user menu to initiate the flow, but I'm happy to budge on this if there are any thoughts, objections, etc.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
N/A
How to test 🧪
I recommend reviewing these tests using Cypress's debugger (via
yarn cy:debug
) so you can see them in action and observe any details, etc. that might stand out.Alternatively, you can run the test from the command line:
yarn && yarn build && yarn start:manager:ci
, then:yarn cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts"
As an Author I have considered 🤔
Check all that apply