-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-7859]: Upgrade MSW to 2.2.3 #10285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all generated via npx msw init
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you for taking this on 👏 🎉
I left two small requests
); | ||
}, | ||
{ | ||
once: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i am not seeing this - the once seems to work fine for me in chrome/safari
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🙏🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly I'm getting a lot of failures! The fact that it's passing in CI and on other machines makes me think it's probably a performance issue with my Mac, but @abailly-akamai would you mind if I take a closer look at this / try reproducing / examining any notices and warnings just to rule out any issues before merging? I'll try to follow up before leaving today! Edit: Never mind! Got only a few failures on re-run, most of them are the same ones that are already present in |
Description 📝
This update brings MSW 2.2.3 to Cloud Manager
It is a major update with breaking changes, hence the large amount of files touched.
Changes 🔄
yargs-parser
for that purpose)serverHandlers.ts
(it was not fun)Preview 📷
No visual change to be expected
How to test 🧪
Prerequisites
yarn clean
yarn && yarn up
Verification steps
As an Author I have considered 🤔
Check all that apply