fix: [M3-7862] - Fix display of TagsPanel in read-only entities

[hkhalil-akamai]

Description 📝

#10227 disables the TagPanel component for read-only entities. However, this change would not work correctly for non-Linode entities, such as domains and nodebalancers, since it was hard-coded to grantType: 'linode'.

Changes 🔄

• Fixes hard-coded grantType value
• Moves useIsResourceRestricted out of TagsPanel and into each respective component

Target release date 🗓️

3/18/2024

How to test 🧪

Prerequisites

• Create and log in to a restricted user with a read-only Domain and NodeBalancer.

Reproduction steps

• While logged in to the restricted user, navigate to the read-only Domain/NodeBalancer
• Observe that the Add Tag button is not disabled
• Observe that trying to add a tag results in an Unauthorized Error.

Verification steps

• Follow reproduction steps above
• Verify that Add Tag button is disabled

As an Author I have considered 🤔

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[hkhalil-akamai]

It's better to call this hook in each respective component instead of cluttering TagsPanel with unrelated logic.

[hkhalil-akamai]

It seems like restricted users can't view Kubernetes clusters at all, so the logic in this file may have no effect.

[github-actions]

Coverage Report: ❌
Base Coverage: 81.64%
Current Coverage: 81.63%

[dwiley-akamai]

For Domains, should we provide some sort of indication as to why the tags are disabled? For NodeBalancers, we have a notice at the top so the reason can at least be ascertained. Maybe explanatory hover text could be appropriate here in the Domain case? Alternatively, we could give a similar treatment to Domains, with a notice at the top (this could be a separate ticket).

NodeBalancer	Domain

[hkhalil-akamai]

For Domains, should we provide some sort of indication as to why the tags are disabled? For NodeBalancers, we have a notice at the top so the reason can at least be ascertained. Maybe explanatory hover text could be appropriate here in the Domain case? Alternatively, we could give a similar treatment to Domains, with a notice at the top (this could be a separate ticket).

Going to defer to @jaalah-akamai, who's leading this project -- maybe this should be a follow-up change?

[jaalah-akamai]

For Domains, should we provide some sort of indication as to why the tags are disabled?

@dwiley-akamai No because we're going to update the domains section next, so it will also have a banner. We're currently working our way through each feature or resource entity.

[dwiley-akamai]

Disabled TagsPanel for restricted users on read-only entities for Linodes (card view & on Details page), Domains, and NodeBalancers ✅

[dwiley-akamai]

If the read-only logic isn't doing anything for LKE, we should remove the code IMO. Or if API will support it in the future, add a @todo placeholder about it and comment the grant-related code out

[hana-akamai]

There seems to be an issue loading tags for a restricted user that has r/w Nodebalancer access

Screen.Recording.2024-03-22.at.10.55.46.AM.mov

[hkhalil-akamai]

There seems to be an issue loading tags for a restricted user that has r/w Nodebalancer access

Screen.Recording.2024-03-22.at.10.55.46.AM.mov

Good catch! Seems to be caused by the way react query v4 defines isLoading. Addressed in c14561.