-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Resolve OBJ create and delete E2E test flake #10245
test: Resolve OBJ create and delete E2E test flake #10245
Conversation
Coverage Report: ✅ |
Thanks @jaalah-akamai, pushed a fix for that! Very glad you caught that as it would've been a guaranteed failure for all of our test accounts with no buckets 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repeat
command is useful, thanks for including that!
This test passed consistently for me, and your 50x good runs are good assurance that the flake is resolved. 🚀
One note, though: in some subsequent runs I'd kicked off in the background after that initial 5, I've seen this failure occasionally (twice within ~20 runs): I haven't seen it when watching the test run in debug mode, didn't get to the video output before it was overwritten, and not sure why this would be happening if we've got our |
Thanks @mjac0bs! I'll take a look at this before merging, and if I can reproduce it I'll try to fix it 👍 I was using (Also worth pointing out that I'm experimenting with some Jenkins pipeline changes using this PR, so if you see unusual results for the |
@mjac0bs I've been totally unable to reproduce this locally (tried something like 80 times 😭) but I did find a recording of it happening in Cypress. I wrote up M3-7850 to revisit this soon! |
…eature/namespace-create * 'develop' of https://github.com/vrajesh73/manager: (89 commits) fix: [M3-7269] - Display parent email in user menu when no company name is available for restricted parent user (linode#10248) fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users (linode#10233) upcoming: [M3-7616] - Add Placement Groups Events and Notifications (linode#10221) upcoming: [M3-7816-v2] - Adjust logic for when to show Switch Account button (linode#10266) fix: [M3-7831] - Persisting error messages in ACLB delete dialogs (linode#10254) upcoming: [M3-7842] - Update Assign Linode Drawer and improve query skipping (linode#10263) upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions (linode#10222) test: Fix test flake for Images landing page test (linode#10267) fix: [M3-7824] - ACLB TCP Rule Creation and other fixes (linode#10264) refactor: [M3-7687] - Linodes Restricted User Experience 2/2 (linode#10227) test: Resolve OBJ create and delete E2E test flake (linode#10245) upcoming: [M3-7723] - Placement Group feature flag as object (linode#10256) chore(deps): Bump sanitize-html from 2.11.0 to 2.12.1 (linode#10247) change: [M3-7813] - Allow the disabling of the TypeToConfirm input (linode#10251) upcoming: [M3-7839] - Change Business Partner to Parent User (linode#10259) upcoming: [M3-7835] - Adjust user table column count (linode#10252) upcoming: [M3 7738] - Update Placement Group Create & Edit Drawers (linode#10205) refactor: [M3-7437] - Use `@lukemorales/query-key-factory` for Profile Queries (linode#10241) fix: React Query `updateInPaginatedStore` helper function not working as expected (linode#10249) test: [M3-7497] - Add tests for child user verification banner (linode#10204) ... # Conflicts: # packages/manager/src/MainContent.tsx # packages/manager/src/dev-tools/FeatureFlagTool.tsx
Description 📝
This resolves the test failures that we've recently been seeing in
object-storage.e2e.spec.ts
. There are a couple issues at play that contribute to these failures:This PR only seeks to resolve test failures related to these behaviors, and it does so by waiting for all related API requests to resolve before attempting to create a Bucket. Because Cloud makes an indeterminate number of requests to fetch Buckets, the test waits for the loader to disappear instead of intercepting and waiting on the requests directly.
I was able to reproduce these failures easily on
develop
, and after making these changes I ran the test on repeat 50 times and all 50 runs passed.Changes 🔄
How to test 🧪
We can lean on CI for this, but you can use this command to run the tests locally:
yarn cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"
If you want to run them repeatedly, you can use this command if you're using
zsh
as your shell:repeat 5 yarn cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"
As an Author I have considered 🤔
Check all that apply