Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-7668] - Right align chart tooltip data points #10078

Merged
merged 2 commits into from
Jan 18, 2024
Merged

change: [M3-7668] - Right align chart tooltip data points #10078

merged 2 commits into from
Jan 18, 2024

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Jan 18, 2024 •
edited
Loading

Description 📝

Right justify the chart tooltip datapoints so that they are more discernible as suggested by Kendall/Andrew

Preview 📷

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have a Linode that's been running for a while

Verification steps

(How to verify changes)

  • Hover over a chart (like in the Linode Details Analytics tab) to see the tooltip text. Data points should be right aligned

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Recharts Effort to replace chartjs library label Jan 18, 2024
@hana-akamai hana-akamai self-assigned this Jan 18, 2024
@hana-akamai hana-akamai marked this pull request as ready for review January 18, 2024 22:14
@hana-akamai hana-akamai requested a review from a team as a code owner January 18, 2024 22:14
@hana-akamai hana-akamai requested review from mjac0bs and bnussman-akamai and removed request for a team January 18, 2024 22:14
bnussman-akamai
bnussman-akamai approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and seems much cleaner! So exited to see this in prod

mjac0bs
mjac0bs approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 📈 🚢

Screenshot 2024-01-18 at 3 58 38 PM

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jan 18, 2024
@hana-akamai hana-akamai merged commit 162f471 into linode:develop Jan 18, 2024
17 of 18 checks passed
@hana-akamai hana-akamai deleted the M3-7668-right-align-chart-tooltip-data-points branch January 18, 2024 23:02
This was referenced Jan 18, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjac0bs mjac0bs mjac0bs approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

Assignees

@hana-akamai hana-akamai

Labels
Approved Multiple approvals and ready to merge! Recharts Effort to replace chartjs library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hana-akamai @mjac0bs @bnussman-akamai