Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-7638] - Standardize Copy Icon Color Variations in CopyableTextField #10073

Merged
merged 3 commits into from
Jan 18, 2024
Merged

fix: [M3-7638] - Standardize Copy Icon Color Variations in CopyableTextField #10073

merged 3 commits into from
Jan 18, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Jan 18, 2024 •
edited
Loading

Description 📝

Standardize Copy Icon Color Variations in CopyableTextField.

Preview 📷

Before After
image image
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Verify all references of CopyableTextField.
  • Ensure there is no regression.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner January 18, 2024 02:17
@cpathipa cpathipa requested review from carrillo-erik and hkhalil-akamai and removed request for a team January 18, 2024 02:17
@cpathipa cpathipa changed the title fix: [M3-7638] - Review and Standardize Copy Icon Color Variations in… fix: [M3-7638] - Standardize Copy Icon Color Variations in CopyableTextField Jan 18, 2024
@cpathipa cpathipa self-assigned this Jan 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 79.85%
Current Coverage: 79.85%

@cpathipa cpathipa mentioned this pull request Jan 18, 2024
Merged
12 tasks
bnussman-akamai
bnussman-akamai approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 18, 2024
@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 18, 2024
@cpathipa cpathipa merged commit 418d50d into linode:develop Jan 18, 2024
18 checks passed
This was referenced Jan 18, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@carrillo-erik carrillo-erik Awaiting requested review from carrillo-erik carrillo-erik is a code owner automatically assigned from linode/frontend

@hkhalil-akamai hkhalil-akamai Awaiting requested review from hkhalil-akamai hkhalil-akamai is a code owner automatically assigned from linode/frontend

Assignees

@cpathipa cpathipa

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpathipa @bnussman-akamai @jaalah-akamai