feat: [M3-7564] – Update OBJ validation #10063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional 'regions' field
dwiley-akamai
requested review from
jdamore-linode,
carrillo-erik and
cpathipa
and removed request for
a team
jdamore-linode
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Approved pending e2e results! Just started a run (they didn't kick off automatically because the PR was in draft and hasn't had any pushes -- pipeline issue I'll fix). I'll keep an eye on the results
Edit: @dwiley-akamai feel free to disregard the e2e test failure or kick off another run -- it's unrelated to your PR
bnussman-akamai
approved these changes
Jan 17, 2024
cpathipa
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Update OBJ validation to reflect the upcoming OBJ Multi-Cluster changes.
Changes to createBucketSchema, which were in scope for this ticket, were already made in #9976.
Changes 🔄
regionsproperty increateObjectStorageKeysSchema(it cannot be an empty array nor null)How to test 🧪
Verification steps
At this stage, the main concern is verifying that this change does not break existing functionality: you should still be able to create Access Keys as you can currently, with no unexpected errors in the UI or in the console.
As an Author I have considered 🤔