Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7260] - Managed Summary layout #10042

Merged

Conversation

hana-akamai
Copy link
Contributor

Description 📝

Fix loading and dark mode styling for the Managed Summary tab

Preview 📷

Before After
before.mov
after.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have an account that's Managed (you can do so via admin)

Reproduction steps

(How to reproduce the issue, if applicable)

  • On another branch, go to /managed/summary and observe the styling loading blip
  • The container background in dark mode does not match the graph.

Verification steps

(How to verify changes)

  • Go to /managed/summary, there should no longer be a styling loading blip.
  • The container background in dark mode should now match the graph.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Bug Fixes for regressions or bugs label Jan 8, 2024
@hana-akamai hana-akamai self-assigned this Jan 8, 2024
@hana-akamai hana-akamai requested a review from a team as a code owner January 8, 2024 21:08
@hana-akamai hana-akamai requested review from mjac0bs and jaalah-akamai and removed request for a team January 8, 2024 21:08
Copy link

github-actions bot commented Jan 8, 2024

Coverage Report:
Base Coverage: 79.86%
Current Coverage: 79.86%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was one of those things that drove me a little nuts every time I saw it -- thanks for fixing!

Screen.Recording.2024-01-08.at.2.18.08.PM.mov

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 8, 2024
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 9, 2024
@hana-akamai hana-akamai merged commit 7a104dc into linode:develop Jan 9, 2024
18 checks passed
@hana-akamai hana-akamai deleted the M3-7260-managed-summary-layout-issue branch January 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants