Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7563] – Add proper support for OBJ Access Key events #10038

Merged

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Add support for obj_access_key_create, obj_access_key_delete, and obj_access_key_update events so that they are properly formatted in the Events dropdown and Events landing page.

Changes πŸ”„

  • Add OBJ Access Key events to eventMessageGenerator.ts

Preview πŸ“·

Screenshot

Screenshot 2024-01-05 at 5 51 26 PM

How to test πŸ§ͺ

Verification steps

  • Create, edit, and delete an OBJ Access Key
  • Observe: OBJ Access Key events should be properly formatted as shown in the screenshot in the Preview section

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai self-assigned this Jan 5, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner January 5, 2024 22:55
@dwiley-akamai dwiley-akamai requested review from carrillo-erik and cpathipa and removed request for a team January 5, 2024 22:55
Copy link

github-actions bot commented Jan 5, 2024

Coverage Report: βœ…
Base Coverage: 79.86%
Current Coverage: 79.86%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-08 at 9 36 01 AM

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwiley-akamai Thank you for formatting the Access Key Events. Is this change part of the OBJ Multi-cluster feature?

@dwiley-akamai
Copy link
Contributor Author

@dwiley-akamai Thank you for formatting the Access Key Events. Is this change part of the OBJ Multi-cluster feature?

Sure thing! I noticed it as an issue while looking into OMC-related stuff so I included the ticket in the epic to make sure we get it addressed (none of this is contingent on the feature flag or unreleased API changes though).

@dwiley-akamai dwiley-akamai merged commit 5bc4323 into linode:develop Jan 8, 2024
17 of 18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-7563-obj-access-key-events branch January 8, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants