test: [M3-7409] - Add GDPR agreement e2e #10033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
jdamore-linode
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
This is awesome, thanks @abailly-akamai! I know this is a draft PR -- happy to re-review if any changes get made
| }), | ||
| ]; | ||
|
|
||
| authenticate(); |
There was a problem hiding this comment.
Suggested change
| authenticate(); |
We only need this when we make calls to the API from within the test so we can safely get rid of it and the import for this test
abailly-akamai
force-pushed
the
M3-7409
branch
from
25ecb3a
to
54a62b6
Compare
abailly-akamai
requested review from
cliu-akamai,
dwiley-akamai and
hana-akamai
and removed request for
a team
abailly-akamai
commented
Jan 5, 2024
| mockAppendFeatureFlags, | ||
| mockGetFeatureFlagClientstream, | ||
| } from 'support/intercepts/feature-flags'; | ||
| import { makeFeatureFlagData } from 'support/util/feature-flags'; |
There was a problem hiding this comment.
just a clean up of unused imports
| component="label" | ||
| htmlFor="gdpr-checkbox" | ||
| style={{ marginLeft: 4 }} | ||
| > |
There was a problem hiding this comment.
Improving the accessibility here. The checkbox was never labeled.
|
Coverage Report: ❌ |
dwiley-akamai
approved these changes
Jan 5, 2024
abailly-akamai
force-pushed
the
M3-7409
branch
from
658673e
to
464aed0
Compare
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Small PR to add e2e coverage for the GDPR agreement panel.
Since we are using existing test accounts it is preferable to mock the response from
account/agreements.Changes 🔄
gdpr-agreement.spec.tsaccount/agreementsReproduction steps
Verification steps
yarn upandyarn cy:debug, pick thegdpr-agreementtest and run itAs an Author I have considered 🤔
Check all that apply