-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7455] - Add child account access column and disable Delete Account button when account has child accounts #10025
Merged
mjac0bs
merged 21 commits into
linode:develop
from
mjac0bs:M3-7455-add-child-access-column-to-users-table-2
Jan 4, 2024
Merged
upcoming: [M3-7455] - Add child account access column and disable Delete Account button when account has child accounts #10025
mjac0bs
merged 21 commits into
linode:develop
from
mjac0bs:M3-7455-add-child-access-column-to-users-table-2
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-access-column-to-users-table
mjac0bs
requested review from
bnussman-akamai,
cpathipa and
jaalah-akamai
and removed request for
a team
January 3, 2024 15:47
jaalah-akamai
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My requested changes from the previous PR have been addressed. Things are looking good. ✅
jdamore-linode
approved these changes
Jan 4, 2024
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Jan 4, 2024
mjac0bs
changed the title
upcoming: [M3-7455] - Add child account access column and disable button when account has child accounts
upcoming: [M3-7455] - Add child account access column and disable Delete Account button when account has child accounts
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add child account access column and disable Close Account button when account has child accounts.
Note: See #10012 (unintentionally closed) for initial reviews.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
How to test 🧪
Prerequisites
Verification steps
As an Author I have considered 🤔
Check all that apply