Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7455] - Add child account access column and disable Delete Account button when account has child accounts #10025

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Jan 3, 2024

Description 📝

Add child account access column and disable Close Account button when account has child accounts.

Note: See #10012 (unintentionally closed) for initial reviews.

Changes 🔄

List any change relevant to the reviewer.

  • Add child account access column
  • Disable Close Account button when account has child accounts

Preview 📷

Before After
Screenshot 2023-12-27 at 3 29 43 PM Screenshot 2023-12-27 at 3 45 56 PM
Screenshot 2023-12-27 at 3 30 15 PM Screenshot 2023-12-27 at 3 30 45 PM

How to test 🧪

Prerequisites

  • MSW on
  • Parent/Child Account flag on

Verification steps

  • Navigate to http://localhost:3000/account/settings and ensure the button is disabled since the current account has a child account, and ensure there is a notice explaining why it is disabled.
  • Navigate to http://localhost:3000/account/users and ensure there is an additional 'Child Account Access' column with accurate labels ('Enabled' and 'Disabled') visible when the active account is a parent user.
    • Edit L1236 of serverHandlers.ts to make the active account something other than a parent user (child/proxy/null) and confirm that the 'Child Account Access' column does not display.
  • Ensure the parent/child feature flag works as expected.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this Jan 3, 2024
@mjac0bs mjac0bs marked this pull request as ready for review January 3, 2024 15:47
@mjac0bs mjac0bs requested a review from a team as a code owner January 3, 2024 15:47
@mjac0bs mjac0bs requested review from bnussman-akamai, cpathipa and jaalah-akamai and removed request for a team January 3, 2024 15:47
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My requested changes from the previous PR have been addressed. Things are looking good. ✅

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 3, 2024
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 4, 2024
@mjac0bs mjac0bs merged commit e5efd97 into linode:develop Jan 4, 2024
34 checks passed
@mjac0bs mjac0bs changed the title upcoming: [M3-7455] - Add child account access column and disable button when account has child accounts upcoming: [M3-7455] - Add child account access column and disable Delete Account button when account has child accounts Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Parent / Child Account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants