-
Notifications
You must be signed in to change notification settings - Fork 358
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: [M3-8183] - Clean up loading components (#10524)
## Description 📝 We have a lot of loading components that are all basically just variations of CircleProgress. This PR cleans up those components. I also moved the overage pricing tooltip text position in the Object Storage Create Bucket drawer to the top so that the tooltip doesn't block the CTA buttons ## How to test 🧪 ### Verification steps (How to verify changes) - Check the affected loading spinners throughout the app
- Loading branch information
1 parent
d52ad40
commit a0c4520
Showing
50 changed files
with
122 additions
and
320 deletions.
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-10524-tech-stories-1716999765184.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Tech Stories | ||
--- | ||
|
||
Clean up loading components ([#10524](https://github.com/linode/manager/pull/10524)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
packages/manager/src/components/CircularProgress.stories.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
packages/manager/src/components/EnhancedSelect/components/LoadingIndicator.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
import { styled } from '@mui/material/styles'; | ||
import * as React from 'react'; | ||
|
||
import { CircularProgress } from 'src/components/CircularProgress'; | ||
import { CircleProgress } from 'src/components/CircleProgress'; | ||
|
||
export const LoadingIndicator = () => { | ||
return <StyledCircularProgress data-testid="input-loading" size={20} />; | ||
return <StyledCircleProgress data-testid="input-loading" size="sm" />; | ||
}; | ||
|
||
const StyledCircularProgress = styled(CircularProgress)(() => ({ | ||
const StyledCircleProgress = styled(CircleProgress)(() => ({ | ||
position: 'relative', | ||
right: 20, | ||
})); |
25 changes: 0 additions & 25 deletions
25
packages/manager/src/components/LandingLoading/LandingLoading.stories.tsx
This file was deleted.
Oops, something went wrong.
57 changes: 0 additions & 57 deletions
57
packages/manager/src/components/LandingLoading/LandingLoading.test.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.