Remove name field from oneClickApps in favor of stackscript label

linode · Oct 16, 2024 · 4aad11e · 4aad11e
1 parent abb8651
commit 4aad11e
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 124 deletions.
diff --git a/packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts b/packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts
@@ -86,7 +86,9 @@ describe('OneClick Apps (OCA)', () => {
       }
 
       cy.findByTestId('one-click-apps-container').within(() => {
-        cy.findAllByLabelText(`Info for "${candidateApp.name}"`)
+        cy.findAllByLabelText(
+          `Info for "${getMarketplaceAppLabel(candidateStackScript.label)}"`
+        )
           .first()
           .scrollIntoView()
           .should('be.visible')
@@ -95,7 +97,7 @@ describe('OneClick Apps (OCA)', () => {
       });
 
       ui.drawer
-        .findByTitle(candidateApp.name)
+        .findByTitle(getMarketplaceAppLabel(candidateStackScript.label))
         .should('be.visible')
         .within(() => {
           cy.findByText(candidateApp.description).should('be.visible');

diff --git a/packages/manager/src/factories/stackscripts.ts b/packages/manager/src/factories/stackscripts.ts
@@ -36,7 +36,6 @@ export const oneClickAppFactory = Factory.Sync.makeFactory<OCA>({
   },
   description: 'A test app',
   logo_url: 'nodejs.svg',
-  name: 'Test App',
   summary: 'A test app',
   website: 'https://www.linode.com',
 });

diff --git a/packages/manager/src/features/Linodes/LinodeCreate/Tabs/Marketplace/utilities.ts b/packages/manager/src/features/Linodes/LinodeCreate/Tabs/Marketplace/utilities.ts
@@ -116,7 +116,6 @@ const getDoesMarketplaceAppMatchQuery = (
   const searchableAppFields = [
     String(app.stackscript.id),
     app.stackscript.label,
-    app.details.name,
     app.details.alt_name,
     app.details.alt_description,
     ...app.details.categories,