Skip to content

Commit

Permalink
chore: [M3-8700] - Rename Linode Create v2 to Linode Create (#11043)
Browse files Browse the repository at this point in the history
* rename linode create directory from `LinodeCreatev2` to `LinodeCreate`

* rename `Linode Createv 2` to `Linode Create` in the codebase

* Added changeset: Rename `Linode Create v2` to `Linode Create`

* fix last rename

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
  • Loading branch information
bnussman-akamai and bnussman authored Oct 4, 2024
1 parent b3f86ee commit 2aeea52
Show file tree
Hide file tree
Showing 132 changed files with 47 additions and 58 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Rename `Linode Create v2` to `Linode Create` ([#11043](https://github.com/linode/manager/pull/11043))
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { randomLabel, randomString } from 'support/util/random';
import { chooseRegion } from 'support/util/regions';
import { stackScriptFactory } from 'src/factories/stackscripts';
import { oneClickApps } from 'src/features/OneClickApps/oneClickAppsv2';
import { getMarketplaceAppLabel } from 'src/features/Linodes/LinodeCreatev2/Tabs/Marketplace/utilities';
import { getMarketplaceAppLabel } from 'src/features/Linodes/LinodeCreate/Tabs/Marketplace/utilities';

import type { StackScript } from '@linode/api-v4';
import { imageFactory, linodeFactory } from 'src/factories';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type {
RegionFilterValue,
} from './RegionSelect.types';
import type { AccountAvailability, Capabilities, Region } from '@linode/api-v4';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreate/types';

const NORTH_AMERICA = CONTINENT_CODE_TO_CONTINENT.NA;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { renderWithThemeAndHookFormContext } from 'src/utilities/testHelpers';

import { Addons } from './Addons';

describe('Linode Create v2 Addons', () => {
describe('Linode Create Addons', () => {
it('should render an "Add-ons" heading', () => {
const { getByText } = renderWithThemeAndHookFormContext({
component: <Addons />,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { Backups } from './Backups';

import type { LinodeCreateFormValues } from '../utilities';

describe('Linode Create V2 Backups Addon', () => {
describe('Linode Create Backups Addon', () => {
it('should render a label and checkbox', () => {
const { getByLabelText } = renderWithThemeAndHookFormContext({
component: <Backups />,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { PrivateIP } from './PrivateIP';

import type { CreateLinodeRequest } from '@linode/api-v4';

describe('Linode Create V2 Private IP Add-on', () => {
describe('Linode Create Private IP Add-on', () => {
it('should render a label and checkbox', () => {
const { getByLabelText } = renderWithThemeAndHookFormContext({
component: <PrivateIP />,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Firewall } from './Firewall';

import type { CreateLinodeRequest } from '@linode/api-v4';

describe('Linode Create v2 Firewall', () => {
describe('Linode Create Firewall', () => {
it('should render a header', () => {
const { getByText } = renderWithThemeAndHookFormContext({
component: <Firewall />,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Summary } from './Summary';

import type { CreateLinodeRequest } from '@linode/api-v4';

describe('Linode Create v2 Summary', () => {
describe('Linode Create Summary', () => {
it('should render a heading based on the Linode label', async () => {
const label = 'my-linode-1';
const { findByText } = renderWithThemeAndHookFormContext({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import React from 'react';
import { Paper } from 'src/components/Paper';
import { Stack } from 'src/components/Stack';
import { Typography } from 'src/components/Typography';
import { Region } from 'src/features/Linodes/LinodeCreatev2/Region';

import { Region } from '../../Region';
import { LinodeSelectTable } from '../../shared/LinodeSelectTable';
import { CloneWarning } from './CloneWarning';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ import { Paper } from 'src/components/Paper';
import { Placeholder } from 'src/components/Placeholder/Placeholder';
import { Stack } from 'src/components/Stack';
import { Typography } from 'src/components/Typography';
import { Region } from 'src/features/Linodes/LinodeCreatev2/Region';
import { useRestrictedGlobalGrantCheck } from 'src/hooks/useRestrictedGlobalGrantCheck';
import { useAllImagesQuery } from 'src/queries/images';
import { useRegionsQuery } from 'src/queries/regions/regions';

import { Region } from '../Region';
import { getGeneratedLinodeLabel } from '../utilities';

import type { LinodeCreateFormValues } from '../utilities';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { makeResourcePage } from 'src/mocks/serverHandlers';
import { HttpResponse, http, server } from 'src/mocks/testServer';
import { renderWithTheme } from 'src/utilities/testHelpers';

import { AppDetailDrawerv2 } from './AppDetailDrawer';
import { AppDetailDrawer } from './AppDetailDrawer';

describe('AppDetailDrawer', () => {
it('should render an app', async () => {
Expand All @@ -19,7 +19,7 @@ describe('AppDetailDrawer', () => {
);

const { findByText, getByText } = renderWithTheme(
<AppDetailDrawerv2 onClose={vi.fn()} open stackScriptId={401697} />
<AppDetailDrawer onClose={vi.fn()} open stackScriptId={401697} />
);

// Verify title renders
Expand Down Expand Up @@ -49,7 +49,7 @@ describe('AppDetailDrawer', () => {
it('should call onClose if the close button is clicked', async () => {
const onClose = vi.fn();
const { getByLabelText } = renderWithTheme(
<AppDetailDrawerv2 onClose={onClose} open={true} stackScriptId={1} />
<AppDetailDrawer onClose={onClose} open={true} stackScriptId={1} />
);

await userEvent.click(getByLabelText('Close drawer'));
Expand All @@ -59,7 +59,7 @@ describe('AppDetailDrawer', () => {

it('should not render if open is false', async () => {
const { container } = renderWithTheme(
<AppDetailDrawerv2 onClose={vi.fn()} open={false} stackScriptId={1} />
<AppDetailDrawer onClose={vi.fn()} open={false} stackScriptId={1} />
);

expect(container).toBeEmptyDOMElement();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ interface Props {
stackScriptId: number | undefined;
}

export const AppDetailDrawerv2 = (props: Props) => {
export const AppDetailDrawer = (props: Props) => {
const { onClose, open, stackScriptId } = props;
const { classes } = useStyles();
const { apps } = useMarketplaceApps();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import React, { useState } from 'react';

import { Stack } from 'src/components/Stack';
import { Region } from 'src/features/Linodes/LinodeCreatev2/Region';

import { Region } from '../../Region';
import { StackScriptImages } from '../StackScripts/StackScriptImages';
import { UserDefinedFields } from '../StackScripts/UserDefinedFields/UserDefinedFields';
import { AppDetailDrawerv2 } from './AppDetailDrawer';
import { AppDetailDrawer } from './AppDetailDrawer';
import { AppSelect } from './AppSelect';

export const Marketplace = () => {
Expand All @@ -21,7 +21,7 @@ export const Marketplace = () => {
<UserDefinedFields onOpenDetailsDrawer={onOpenDetailsDrawer} />
<Region />
<StackScriptImages />
<AppDetailDrawerv2
<AppDetailDrawer
onClose={() => setDrawerStackScriptId(undefined)}
open={drawerStackScriptId !== undefined}
stackScriptId={drawerStackScriptId}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { ImageSelectv2 } from 'src/components/ImageSelectv2/ImageSelectv2';
import { Paper } from 'src/components/Paper';
import { Stack } from 'src/components/Stack';
import { Typography } from 'src/components/Typography';
import { Region } from 'src/features/Linodes/LinodeCreatev2/Region';
import { useRestrictedGlobalGrantCheck } from 'src/hooks/useRestrictedGlobalGrantCheck';

import { Region } from '../Region';
import { getGeneratedLinodeLabel } from '../utilities';

import type { LinodeCreateFormValues } from '../utilities';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React from 'react';

import { Stack } from 'src/components/Stack';
import { Region } from 'src/features/Linodes/LinodeCreatev2/Region';

import { Region } from '../../Region';
import { StackScriptImages } from './StackScriptImages';
import { StackScriptSelection } from './StackScriptSelection';
import { UserDefinedFields } from './UserDefinedFields/UserDefinedFields';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { renderWithThemeAndHookFormContext } from 'src/utilities/testHelpers';

import { UserData } from './UserData';

describe('Linode Create v2 UserData', () => {
describe('Linode Create UserData', () => {
it('should render if the selected image supports cloud-init and the region supports metadata', async () => {
const image = imageFactory.build({ capabilities: ['cloud-init'] });
const region = regionFactory.build({ capabilities: ['Metadata'] });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@ import React from 'react';

import { renderWithTheme } from 'src/utilities/testHelpers';

import { LinodeCreatev2 } from '.';
import { LinodeCreate } from '.';

describe('Linode Create', () => {
it('Should not render VLANs when cloning', () => {
const { queryByText } = renderWithTheme(<LinodeCreatev2 />, {
const { queryByText } = renderWithTheme(<LinodeCreate />, {
MemoryRouter: { initialEntries: ['/linodes/create?type=Clone+Linode'] },
});

expect(queryByText('VLAN')).toBeNull();
});

it('Should not render access panel items when cloning', () => {
const { queryByText } = renderWithTheme(<LinodeCreatev2 />, {
const { queryByText } = renderWithTheme(<LinodeCreate />, {
MemoryRouter: { initialEntries: ['/linodes/create?type=Clone+Linode'] },
});

Expand All @@ -23,7 +23,7 @@ describe('Linode Create', () => {
});

it('Should not render the region select when creating from a backup', () => {
const { queryByText } = renderWithTheme(<LinodeCreatev2 />, {
const { queryByText } = renderWithTheme(<LinodeCreate />, {
MemoryRouter: { initialEntries: ['/linodes/create?type=Backups'] },
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { isEmpty } from '@linode/api-v4';
import * as Sentry from '@sentry/react';
import { useQueryClient } from '@tanstack/react-query';
import { useSnackbar } from 'notistack';
import React, { useEffect, useRef } from 'react';
Expand Down Expand Up @@ -64,7 +63,7 @@ import type {
} from './utilities';
import type { SubmitHandler } from 'react-hook-form';

export const LinodeCreatev2 = () => {
export const LinodeCreate = () => {
const { params, setParams } = useLinodeCreateQueryParams();
const { secureVMNoticesEnabled } = useSecureVMNoticesEnabled();
const { data: profile } = useProfile();
Expand Down Expand Up @@ -163,19 +162,6 @@ export const LinodeCreatev2 = () => {
previousSubmitCount.current = form.formState.submitCount;
}, [form.formState, handleLinodeCreateAnalyticsFormError]);

/**
* Add a Sentry tag when Linode Create v2 is mounted
* so we differentiate errors.
*
* @todo remove once Linode Create v2 is live for all users
*/
useEffect(() => {
Sentry.setTag('Linode Create Version', 'v2');
return () => {
Sentry.setTag('Linode Create Version', undefined);
};
}, []);

return (
<FormProvider {...form}>
<DocumentTitleSegment segment="Create a Linode" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { TableRowError } from 'src/components/TableRowError/TableRowError';
import { TableRowLoading } from 'src/components/TableRowLoading/TableRowLoading';
import { TableSortCell } from 'src/components/TableSortCell';
import { Typography } from 'src/components/Typography';
import { SelectLinodeCard } from 'src/features/Linodes/LinodeCreatev2/shared/SelectLinodeCard';
import { PowerActionsDialog } from 'src/features/Linodes/PowerActionsDialogOrDrawer';
import { useOrder } from 'src/hooks/useOrder';
import { usePagination } from 'src/hooks/usePagination';
Expand All @@ -33,6 +32,7 @@ import {
useLinodeCreateQueryParams,
} from '../utilities';
import { LinodeSelectTableRow } from './LinodeSelectTableRow';
import { SelectLinodeCard } from './SelectLinodeCard';

import type { LinodeCreateFormValues } from '../utilities';
import type { Linode } from '@linode/api-v4';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export interface LinodeCreateFormValues extends CreateLinodeRequest {

export interface LinodeCreateFormContext {
/**
* Profile data is used in the Linode Create v2 resolver because
* Profile data is used in the Linode Create resolver because
* restricted users are subject to different validation.
*/
profile: Profile | undefined;
Expand Down
8 changes: 4 additions & 4 deletions packages/manager/src/features/Linodes/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ const LinodesDetail = React.lazy(() =>
default: module.LinodeDetail,
}))
);
const LinodesCreatev2 = React.lazy(() =>
import('./LinodeCreatev2').then((module) => ({
default: module.LinodeCreatev2,
const LinodesCreate = React.lazy(() =>
import('./LinodeCreate').then((module) => ({
default: module.LinodeCreate,
}))
);

export const LinodesRoutes = () => {
return (
<React.Suspense fallback={<SuspenseLoader />}>
<Switch>
<Route component={LinodesCreatev2} path="/linodes/create" />
<Route component={LinodesCreate} path="/linodes/create" />
<Route component={LinodesDetail} path="/linodes/:linodeId" />
<Route component={LinodesLandingWrapper} exact path="/linodes" strict />
<Redirect to="/linodes" />
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Linodes/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { LinodeCreateType } from './LinodeCreatev2/types';
import type { LinodeCreateType } from './LinodeCreate/types';
import type { BaseQueryParams } from 'src/utilities/queryParams';

export type DialogType =
Expand Down
2 changes: 0 additions & 2 deletions packages/manager/src/features/OneClickApps/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ export interface OCA {
/**
* Set isNew to `true` if you want the app to show up in the "New apps"
* section on the Linode Create flow.
*
* @note this value only affects Linode Create v2
*/
isNew?: boolean;
logo_url: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
hasRegionReachedPlacementGroupCapacity,
} from './utils';

import type { LinodeCreateType } from '../Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from '../Linodes/LinodeCreate/types';
import type { PlacementGroupsCreateDrawerProps } from './types';
import type {
CreatePlacementGroupPayload,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { UserDefinedField } from '@linode/api-v4/lib/stackscripts';
import { APIError } from '@linode/api-v4/lib/types';
import Grid from '@mui/material/Unstable_Grid2';
import * as React from 'react';
import { Link } from 'react-router-dom';
Expand All @@ -13,17 +11,19 @@ import { Typography } from 'src/components/Typography';
import {
getIsUDFHeader,
getIsUDFMultiSelect,
getIsUDFSingleSelect,
getIsUDFPasswordField,
getIsUDFSingleSelect,
separateUDFsByRequiredStatus,
} from 'src/features/Linodes/LinodeCreatev2/Tabs/StackScripts/UserDefinedFields/utilities';
} from 'src/features/Linodes/LinodeCreate/Tabs/StackScripts/UserDefinedFields/utilities';

import { AppInfo } from './AppInfo';
import UserDefinedMultiSelect from './FieldTypes/UserDefinedMultiSelect';
import { UserDefinedSelect } from './FieldTypes/UserDefinedSelect';
import UserDefinedText from './FieldTypes/UserDefinedText';
import { StyledBox, StyledPaper } from './UserDefinedFieldsPanel.styles';

import type { APIError, UserDefinedField } from '@linode/api-v4';

interface Props {
appLogo?: JSX.Element;
errors?: APIError[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
} from './VPCCreateForm.styles';

import type { APIError } from '@linode/api-v4';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreate/types';
import type { LinodeCreateQueryParams } from 'src/features/Linodes/types';
import type { SubnetFieldState } from 'src/utilities/subnets';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { StyledBodyTypography } from './VPCCreateForm.styles';

import type { Region } from '@linode/api-v4';
import type { FormikErrors } from 'formik';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreate/types';
import type { LinodeCreateQueryParams } from 'src/features/Linodes/types';
import type { CreateVPCFieldState } from 'src/hooks/useCreateVPC';

Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/hooks/useCreateVPC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import type {
CreateSubnetPayload,
CreateVPCPayload,
} from '@linode/api-v4';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreate/types';
import type { SubnetError } from 'src/utilities/formikErrorUtils';
import type { SubnetFieldState } from 'src/utilities/subnets';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {
FormStepEvent,
LinodeCreateFormEventOptions,
} from './types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreate/types';

/**
* Form Events
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/utilities/analytics/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreatev2/types';
import type { LinodeCreateType } from 'src/features/Linodes/LinodeCreate/types';

// Define a custom type for the _satellite object
declare global {
Expand Down

0 comments on commit 2aeea52

Please sign in to comment.