Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodebalancer Config Changes for VPC integration #689

Merged
merged 29 commits into from
Mar 3, 2025

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Feb 25, 2025

📝 Description

What does this PR do and why is this change necessary?

This is a follow up PR to the previous one where we added changes to enable creating a Nodebalancers in VPC. This PR adds the functionality to allow configuring the Nodebalancer and Nodes in VPC

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

komer3 and others added 25 commits February 11, 2025 08:04
… funcs to allow creation of nb with vpc options
Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
@komer3 komer3 requested a review from a team as a code owner February 25, 2025 16:40
@komer3 komer3 requested review from ykim-akamai and yec-akamai and removed request for a team February 25, 2025 16:40
@lgarber-akamai lgarber-akamai self-requested a review February 26, 2025 20:32
@zliang-akamai zliang-akamai self-requested a review February 26, 2025 20:43
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixtures are passing on my end, thanks for the contribution!

@zliang-akamai zliang-akamai merged commit a56f15e into linode:main Mar 3, 2025
10 checks passed
@zliang-akamai zliang-akamai added the new-feature for new features in the changelog. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants