Nodebalancer VPC support #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… funcs to allow creation of nb with vpc options
Nb vpc updates
komer3
changed the title
komer3
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
lgarber-akamai
approved these changes
Feb 20, 2025
zliang-akamai
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR add couple new endpoint that allow us to manage VPC configuration for NodeBalancers in VPCs. We are also updating couple structs to allow passing info about VPC when Nodebalancer is created.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
Need to update Nodebalancer.go to allow NB creation with VPC config. Once that is updated, we can run the new integration tests
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.