add support for the type field when creating nodebalancers #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljohnson92
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
eljohnson92
force-pushed
the
support_nb_types
branch
from
9e9e422 to
7626a27
Compare
rahulait
reviewed
Feb 5, 2025
Merged
10 tasks
eljohnson92
force-pushed
the
support_nb_types
branch
from
7626a27 to
c70a957
Compare
yec-akamai
reviewed
Feb 11, 2025
There was a problem hiding this comment.
@eljohnson92 Thank you for the contribution! Can you add test cases, i.e. integration test, to test through the new field?
There are examples you can find here: https://github.com/linode/linodego/tree/main/test/integration
And you can test and generate the fixtures by running make TEST_ARGS="-run $TestCaseName" fixtures
|
@yec-akamai I can definitely add this, the only issue is currently the Linode API does not return what the type is from a created NB so we can test that submission works but not validate it is the right type, do you think just submission is good for now? |
yec-akamai
reviewed
Feb 13, 2025
yec-akamai
reviewed
Feb 13, 2025
eljohnson92
force-pushed
the
support_nb_types
branch
from
c599690 to
9db149b
Compare
yec-akamai
approved these changes
Feb 26, 2025
ykim-akamai
approved these changes
Feb 28, 2025
eljohnson92
force-pushed
the
support_nb_types
branch
from
9db149b to
301ae3b
Compare
eljohnson92
force-pushed
the
support_nb_types
branch
from
301ae3b to
d9e6253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
This PR adds support for a new
typeof nodebalancer calledpremium✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
This can be tested by sending a request for an explicit
commonorpremiumnodebalancer typeHow do I run the relevant unit/integration tests?