-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610
Merged
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
1b87e78
added reserved field to InstanceIP struct for IP Reservation response
AniJ98 311ecfc
Reserved IP resource for handling IP reservation API's
AniJ98 7fb337e
Added integration test covering multiple scenarios of reserving IP ad…
AniJ98 1c6a8ab
The fixture files for different scenarios of IP Reservation - EndToEn…
AniJ98 fd426cc
Updated the fixture files with responses after the user has permissio…
AniJ98 bed7ce0
Changed the error message to relay invalid token for insufficient per…
AniJ98 4cc42a6
Updated the error message for Insufficient Permission tests to displa…
AniJ98 11fd3cb
Made changes to Delete, List, Get, Reserve, EndtoEnd fixtures to rec…
AniJ98 4d24fd1
changed variable name from id to address to keep it consistent with o…
AniJ98 a265fd4
Made changes to variable names, achanged logf statements to errorf an…
AniJ98 49d14a6
changed fixture file names to improve consistency, re-recorded fixtur…
AniJ98 bd106fa
removed debugging fmt statement
AniJ98 cd7fa48
Made changes to reserve IP addresses before listing them using fitler…
AniJ98 d52a33f
uncommenting unaffected tests
AniJ98 cb81bc2
Made changes to error messages, added mandatory checks and re-recorde…
AniJ98 456d0f2
Added new middleware system (#571)
ezilber-akamai 1867029
build(deps): bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 (#574)
dependabot[bot] af6a7bd
build(deps): bump golang.org/x/text from 0.17.0 to 0.18.0 (#575)
dependabot[bot] b25e83d
new: Add support LKE, Volume, NodeBalancer, and network transfer pric…
lgarber-akamai 3bb8dc0
Add test case for ip limit exceed
AniJ98 ce34304
add cleanup for TestReservedIPAddresses_ExceedLimit
ykim-akamai 8627e4f
added interactions to fixture and changed the ecpected error message
AniJ98 663e798
Added note indicating feature is currently not available to all users
AniJ98 5bb2bc1
Merge branch 'main' into main
AniJ98 138c163
added support for creating a linode with reserved IP address along wi…
AniJ98 4b44bd8
Added support for adding additional reserved IP to linodes along with…
AniJ98 35610a0
added ipv4 field in the InstanceCreateOptions struct
AniJ98 809b407
moved InstanceReservedIPOptions and the method to AddReservedIPToInsa…
AniJ98 b559ee8
Split the variants tests of createInstanceWithReservedIP into individ…
AniJ98 402c77a
Re-recorded fixtures after splitting variants test into individual te…
AniJ98 30eeda7
added teardown funcitnality to handle accidental instance creations
AniJ98 8909bd6
removed unnecessary defer keyword from test functions
AniJ98 9b15909
moved tests related to creating a linode with reserved IP and adding …
AniJ98 97ccd6b
Removing the sensitive token from the previous commit
AniJ98 be7b869
Merge pull request #5 from AniJ98/ipreservation-existingendpoints-clean
AniJ98 ff906e3
Merge branch 'linode:main' into main
AniJ98 2907529
made changes to maintain consistency and improve readability
AniJ98 6f8ad3c
Merge branch 'main' into main
zliang-akamai 39323ef
added tests for deletion of linode created with reserved IP address
AniJ98 c9a70b8
added test for verifying the status of the reserved field when listin…
AniJ98 2752177
Added support for existing resources to support reserved IP feature a…
AniJ98 30435e2
Updated fixtures with required interactions for reserved IP feature a…
AniJ98 25bcf81
changed the name of the test function to keeop it more succinct
AniJ98 2157efd
Merge branch 'linode:main' into main
AniJ98 62d2550
setting reserved as an optional field
AniJ98 4789287
Made change to make reserved a part of the update IP address function…
AniJ98 968f780
Merge pull request #6 from AniJ98/ipreservation-remainingendpoints
AniJ98 8a19216
Merge branch 'linode:main' into main
AniJ98 2181fb1
Merge branch 'main' into main
AniJ98 b716ca2
Removed test for exceeding IP MAX and changed the type of the reserve…
AniJ98 e809bf8
Merge branch 'main' into main
AniJ98 0fbe6ff
Merge pull request #7 from AniJ98/ipreservation-remainingendpoints
AniJ98 73a1b3b
Merge branch 'main' into main
AniJ98 4af2cc7
Changed struct name from LinodeReserveIPOptions to AllocateReserveIPO…
AniJ98 0a45fcd
Merge pull request #8 from AniJ98/ipreservation-remainingendpoints
AniJ98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite related to this PR but I'm curious about what the difference between
POST networking/reserved/ips
andPOST networking/ips
(with reserved ==true
) is. Is the latter effectively just an alias of the former with a bit more functionality?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question! We are currently supporting creation of reserved IP's through both
POST networking/reserved/ips
andPOST networking/ips (with reserved == true)
. The only difference is that along with creation we are also able to assign reserved IP's to linodes usingPOST networking/ips (with reserved == true)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!