Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support created and updated for domain records #600

Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to add the missing fields for DomainRecord

✔️ How to Test

make fixtures ARGS="-run TestDomainRecord"

@zliang-akamai zliang-akamai requested a review from a team as a code owner October 31, 2024 20:42
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-akamai and removed request for a team October 31, 2024 20:42
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for tidying up the error handling logic!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass locally. Nice work!

@zliang-akamai zliang-akamai merged commit 4c3fcf0 into linode:main Nov 7, 2024
7 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/domain-created-updated-dates branch November 7, 2024 19:01
@zliang-akamai zliang-akamai added the new-feature for new features in the changelog. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants