Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for missing Account-related endpoints #598

Merged

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for the following Account endpoints:

  • PUT account
  • GET account/agreements
  • POST account/agreements
  • GET account/maintenance

✔️ How to Test

Unit Tests

make testunit

Integration Tests

make fixtures ARGS="-run TestAccountAgreements_Get"
make fixtures ARGS="-run TestAccountMaintenances_List"

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner October 30, 2024 17:55
@ezilber-akamai ezilber-akamai requested review from zliang-akamai and ykim-akamai and removed request for a team October 30, 2024 17:55
@ezilber-akamai ezilber-akamai force-pushed the TPT-3232-missing-account-endpoints branch from 1c3e5f4 to c82593c Compare October 30, 2024 18:03
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Oct 30, 2024
account.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unit and integration tests are passing locally. Thanks for adding the unit tests as well!

@ezilber-akamai ezilber-akamai merged commit b6c358f into linode:main Nov 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants