Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Resty as a dependency #576

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Linodego currently uses the go-resty package to manage all HTTP requests made to the API. This includes logic for authentication, JSON marshaling/unmarshaling, request retries, and debug outputs.

Unfortunately this package has caused various issues for linodego users, including:

  • Various upstream race conditions prevent linodego from being thread-safe
  • Uncommitted maintainers lead to difficulty quickly releasing patches for critical issues
  • Bloated dependency tree can cause downstream dependency conflicts
  • Less flexibility due to limited access to the underlying HTTP client

Because of these issues, Resty is being dropped as a dependency in favor of the mature and widely adopted net/http package.

✔️ How to Test

TBD

@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Sep 6, 2024
@ezilber-akamai ezilber-akamai force-pushed the TPT-2965-drop-resty branch 4 times, most recently from bc4dc02 to 519fdcd Compare September 11, 2024 17:33
@ezilber-akamai ezilber-akamai force-pushed the TPT-2965-drop-resty branch 3 times, most recently from 27bad2e to 117b42b Compare September 18, 2024 20:18
@ezilber-akamai ezilber-akamai force-pushed the TPT-2965-drop-resty branch 2 times, most recently from 7fd943a to b87030d Compare September 20, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant