Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Block Storage Encryption #572

Merged

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Aug 28, 2024

📝 Description

Added support for Block Storage Encryption across the following endpoints:

  • POST /volumes
  • GET /volumes
  • GET /volumes/<volume_id>
  • GET /regions
  • GET /regions/<region_id>
  • GET /linode/instances
  • GET /linode/instances/<linode_id>
  • GET /account

✔️ How to Test

Integration Tests

  • make ARGS="-run TestRegions_blockStorageEncryption" fixtures
  • make ARGS="-run TestVolume_Get_withEncryption" fixtures
  • make ARGS="-run TestVolume_Create_withEncryption" fixtures
  • make ARGS="-run TestInstance_withBlockStorageEncryption" fixtures

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner August 28, 2024 14:45
@ezilber-akamai ezilber-akamai requested review from ykim-akamai and yec-akamai and removed request for a team August 28, 2024 14:45
@ezilber-akamai ezilber-akamai added new-feature for new features in the changelog. do-not-merge PRs that should not be merged until the commented issue is resolved labels Aug 28, 2024
@ezilber-akamai ezilber-akamai marked this pull request as draft September 18, 2024 19:27
@ezilber-akamai ezilber-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Oct 10, 2024
@ezilber-akamai ezilber-akamai marked this pull request as ready for review October 10, 2024 19:39
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my end! Just a nitpick:

test/integration/instances_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, integration tests all pass locally

@ezilber-akamai ezilber-akamai merged commit 9bbcf49 into linode:main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants