-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated nodebalancer_firewalls to object_storage_clusters to request helpers #544
Migrated nodebalancer_firewalls to object_storage_clusters to request helpers #544
Conversation
@ezilber-akamai Just a heads up, this PR might run into some conflicts with #522 depending on which one is merged first 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing on my end, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests all pass with new fixtures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and tests seem to be passing, nice work!
📝 Description
Migrated nodebalancer_firewalls to object_storage_clusters to request helpers