feature: Add helper functions for working with errors #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesv
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
This pull request adds two functions to the public API for this package: * `ErrHasStatus(error, ...int)` attempts to unwrap the provided error to an `*Error` and see if its status code matches any of the status codes provided. * `IsNotFound` is a thin wrapper over ErrHasStatus(err, http.StatusNotFound).
zliang-akamai
approved these changes
Mar 7, 2024
You're most welcome, @zliang-akamai! I had a thought earlier: should these "helper" functions exist in the base package for the module, or do you think they could/should be moved into a |
zliang-akamai
requested review from
a team,
ykim-1 and
yec-akamai
and removed request for
a team
|
Hi @nesv, I think it will be fine to remain in the base package for now. We can discuss moving it to an error related sub-package in the future when the base package becomes larger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds two functions to the public API for this package:
ErrHasStatus(error, ...int)attempts to unwrap the provided error to an*Errorand see if its status code matches any of the status codes provided.IsNotFoundis a thin wrapper overErrHasStatus(err, http.StatusNotFound)for a subjectively-common use case.Implements #460
✔️ How to Test