Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that LinodeID matches before detach. #153

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

Michkov
Copy link
Contributor

@Michkov Michkov commented Jan 15, 2024

Avoid calling detach when Volume is assigned to different LinodeID.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@Michkov Michkov requested a review from luthermonson January 15, 2024 12:28
Avoid calling detach when Volume is assigned to different LinodeID.
@Michkov Michkov force-pushed the ensure_linodeid_in_detach branch from 16fed95 to dee8318 Compare January 15, 2024 13:53
@luthermonson
Copy link
Contributor

Ran 5 of 5 Specs in 102.682 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped

@luthermonson luthermonson merged commit c756d5e into linode:main Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants